-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
I've added some comment there. But generally looks fine, and useful!
> I have a more substantial contribution I'm working on (a live, graphical
> VM memory monitor utility for dom0), but thought I'd submit this smaller
> patch first to get my feet with with the process.
Generally all is ok. For reference, here is info:
https://www.qubes-os.org/doc/source-code/#how-to-send-patches
In the future, in addition to pushing to github, you can open pull
request there. This will ease review process and track it progress.
In addition to that, especially for bigger changes, it's a good idea to
send a message here (just like you've just done), to reach people not
monitoring github.
- --
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJYG4BTAAoJENuP0xzK19csTKEH/18yMxICbCNX3SYnmvqu26+Z
ek5aBzMgninzjJOOtlGmrBzEejQfnUyNY9k8490v69LKTZ2atcM0LAbZYpi4XB2I
lFC6HX231BibEGpL8nWNTiwW61Vw7fgA9F5a4Nd2CO/BR0sl06HcQPTAyq8oc5gs
i2ebfaZ51camB2B/ZHH4Q0kfrW2YMPskzGl0kEhS5hD2DlClDbkzAjw9xa7GhTkP
w9TWkQgiYMAqtDhlpRyX7G1Bm6cXCwNjj8GpRY+OQ5ALvhEb1T0sazWuhWPhCmtU
2288Pz88Dffm8rbYv/ixAq4h6r4amp6uihlp43f+svJc+au3aM/Z1kILsSdWy3Y=
=dpnR
-----END PGP SIGNATURE-----