BUG: SimpleThreadPool

20 views
Skip to first unread message

AlexK

unread,
Oct 22, 2008, 6:39:03 AM10/22/08
to Quartz.NET
Hi,

I take latest version of the quartz.net for own project... during
development I found bug:

class Quartz.Simp.SimpleThreadPool

/// <summary>
/// Creates the worker threads.
/// </summary>
/// <param name="threadCount">The thread count.</param>
/// <returns></returns>
protected internal virtual IList CreateWorkerThreads( int
threadCount )
{
workers = new ArrayList();
for( int i = 1 ; i <= count ; ++i )
{
WorkerThread wt = new WorkerThread(
this,
string.Format( CultureInfo.InvariantCulture, "{0}-{1}",
ThreadNamePrefix, i ),
ThreadPriority,
MakeThreadsDaemons );

workers.Add( wt );
}

return workers;
}

see one?!

we pass parameter to the method "threadCount" but do not use it,
instead we use class member "count"...

Fix: replace "count" by "threadCount"

Marko Lahma

unread,
Oct 23, 2008, 3:48:27 AM10/23/08
to quar...@googlegroups.com
Thanks for reporting this, I filed a bug (
http://jira.opensymphony.com/browse/QRTZNET-133 ) and it's now fixed
in trunk.

Cheers,

-Marko

Reply all
Reply to author
Forward
0 new messages