How to contribute

[christianacca]

Can you let me know whether I can / how to contribute to this project?
I have noticed a bug and would like to fix it.

Thanks in advance
Christian

[Marko Lahma]

Easiest way to do this is to check-out the latest trunk from SVN,
create a test case to demonstrate the problem if possible and create a
JIRA issue to the tracker
(http://jira.opensymphony.com/browse/QRTZNET). Then add a patch to the
issue so that it can be reviewed and then if applicable, committed.

Cheers,

Marko

[christianacca]

Thanks and will do

On Sep 4, 9:14 am, "Marko Lahma" <marko.la...@gmail.com> wrote:
> Easiest way to do this is to check-out the latest trunk from SVN,
> create a test case to demonstrate the problem if possible and create a
> JIRA issue to the tracker
> (http://jira.opensymphony.com/browse/QRTZNET). Then add a patch to the
> issue so that it can be reviewed and then if applicable, committed.
>
> Cheers,
>
> Marko
>
> On Thu, Sep 4, 2008 at 11:05 AM, christianacca
>

[christianacca]

I've submitted a bug report and a patch: Quartz-124.

I managed to hit the send button before completing the report but then
couldn't find a link to modify the content (me probably not being
awake!).

I did notice that the tests in DirtyFlagMapTest are mostly ignored and
that there is a failing test RAMJobStoreTest.TestAcquireNextTrigger.
Are these ignores and failure something to be concerned about? For
example should this stop me using this nightly build? If so when is it
likely to be able to fix these up?

Thanks
Christian

On 4 Sep, 09:31, christianacca <christian.crowhu...@btinternet.com>
wrote:

[Marko Lahma]

Hi,

> I've submitted a bug report and a patch: Quartz-124.

Thank you very much. Patch is now applied to trunk.

> I managed to hit the send button before completing the report but then
> couldn't find a link to modify the content (me probably not being
> awake!).

Yep, the first submission allows you to modify description but after
that edit is not permitted, only comments.

> I did notice that the tests in DirtyFlagMapTest are mostly ignored and
> that there is a failing test RAMJobStoreTest.TestAcquireNextTrigger.
> Are these ignores and failure something to be concerned about? For
> example should this stop me using this nightly build? If so when is it
> likely to be able to fix these up?

TestAcquireNextTrigger has always been a small PITA. It runs without
problems alone but as part of the complete run there is a problem.
Haven't been able to determine to cause for this (nor maybe had the
needed patience).

DirtyFlagMap is not complete as it is in Java version of Quartz. There
are ways to change the map without it getting dirty (straight
modifications to entryset, keys or values collections) and this will
cause problems in ADO.NET backed job store when trying to determine
whether to update the data. However, I think that the needed work is
quite big and won't get to 1.0 release and modifying the map this way
is a corner-case in my eyes.

Cheers,

Marko

[christianacca]

So by the sound of it there isn't anything I should be worried about

BTW, just noticed that the SendMailJobTest didn't get added to the
VS05 project. Is that because you're intentioanlly only adding code to
the VS08 solution?

[Marko Lahma]

Good catch. I tend to use only VS2008 so I forgot. I've updated the
2005 project file (didn't update 2003 as I don't even have installed
anymore). The build process for release uses NAnt with csc so project
files aren't an issue for releases though.

-Marko