Contributing GraalVM metadata to Mongo

[clement escoffier]

Hello,

I have been discussing a few native issues with the MongoDB extension with the Mongo development team. The discussion started around the management of crypt, but we also discussed the possibility of moving the MongoDB native metadata to Mongo directly. Mongo requires a few substitutions [0] and some configuration [1], so it would ease the maintenance to have them closer to the driver code. 

We would not remove everything. Typically, the DNS resolver we use [2] is Quarkus-specific and thus would not work elsewhere. Same for our extension points [3].

I'm in favor of moving these metadata, but I wanted your opinion. If you have more technical questions, I've CC two Mongo engineers (as my knowledge about Mongo is quite limited).

Clement

[0] - https://github.com/quarkusio/quarkus/blob/main/extensions/mongodb-client/runtime/src/main/java/io/quarkus/mongodb/runtime/graal/MongoClientSubstitutions.java

[1] - https://github.com/quarkusio/quarkus/blob/main/extensions/mongodb-client/deployment/src/main/java/io/quarkus/mongodb/deployment/MongoClientProcessor.java#L432C50-L432C82

[2] - https://github.com/quarkusio/quarkus/blob/main/extensions/mongodb-client/deployment/src/main/java/io/quarkus/mongodb/deployment/MongoClientProcessor.java#L109

[3] - https://github.com/quarkusio/quarkus/blob/main/extensions/mongodb-client/deployment/src/main/java/io/quarkus/mongodb/deployment/MongoClientProcessor.java#L154

[Georgios Andrianakis]

Sounds reasonable to me

--
You received this message because you are subscribed to the Google Groups "Quarkus Development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to quarkus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/CAKW6fieNa6nMHuoip5itq6_zA5utoRgNd8CYmY4wvmHG4zfbEg%40mail.gmail.com.

[Loïc MATHIEU]

Good for me

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/CALeTM-kHu%2BVqr2EXy0vMvjh5Z08ae-6ykX3HZuau5okMRhGtRg%40mail.gmail.com.

[Guillaume Smet]

Sounds reasonable but my experience with this is that every time we contributed substitutions/reflection registrations to upstream, we had to ignore them anyway because they were not maintained upstream, mostly because of lack of tests, be they on GraalVM proper, or tests that actually exercise Quarkus (which might require specific tweaks).

So if we do that, let's make sure things are properly tested upstream.

--

[clement escoffier]

Hello,

I totally agree, Guillaume. That's more of a question for Jeff and Ashni: how could this be set up?

Clement

[Loïc MATHIEU]

Hi,

Late feedback but when I upstream some Google Cloud Libraries native stuff to the Google Cloud Library SDK they do add tests on their side for native images. They built several small apps with several frameworks (Quarkus was the first implemented) and test that they work in native.

GraalVM now has testing support so their should be easier way to do this these days without having to depends on Quarkus on MongoDB side.

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/CAKW6fifwD_%2B1%3D5s%2BDeiQ8Lpwq7u0QwhODzphEOVR_o04xvPvLw%40mail.gmail.com.