Quarkus & REST Clients

[David Hoffer]

I'm following the following guides regarding having Quarkus mange our REST clients.

https://quarkus.io/guides/rest-client

https://quarkus.io/guides/rest-client-multipart

However the examples show the Path to be provided either in code/annotations and/or in Quarkus application.properties.  In our case the base path is provided by our configuration not Quarkus as it depends on the install network/etc configs.  

How can we use Quarkus to manage the client when the path is a variable from our configs?

-Dave

[Georgios Andrianakis]

You mean that variable is not coming from configuration?

In any case, one can use the REST Client programmatically as shown at: https://quarkus.io/guides/rest-client-reactive#programmatic-client-creation-with-restclientbuilder (the section is in the Reactive REST Client guide, but the feature is actually a MicroProfile REST Client feature, so it works for both the reactive and non-reactive clients)

-Dave

--
You received this message because you are subscribed to the Google Groups "Quarkus Development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to quarkus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/f8fa0a06-e6a2-4762-b9b8-6ba8093541c0n%40googlegroups.com.

[David Hoffer]

Yes its coming from configuration but ours not Quarkus, we maintain deployment/runtime configs in Zookeeper so all nodes get updated in realtime.

Yes creating the REST Client programmatically is what I need here but it seems there is a problem with it reading path params.  Actually two separate problems.

Problem 1:

@Path("{currentUserId}/{fileName}")

Response sendFile( String currentUserId,

                   String fileName,

   @BeanParam() MultipartBody body);

Here it thinks I have no path variables but from the docs my understanding is that if my variable name matches the Path annotation name then I don't need to annotate with @PathParam.

Problem 2:

@Path("{currentUserId}/{fileName}")

Response sendFile( @PathParam(value = "currentUserId") String currentUserId,

                   @PathParam(value = "fileName") String fileName,

   @BeanParam() MultipartBody body);

Here I go ahead and add @PathParam to solve the prior problem but it still fails because the QuarkusRestClientBuilder#verifyInterface method only files one path variable in @Path.  It only files the last one (fileName)

Have I defined this incorrectly?

-Dave

[Georgios Andrianakis]

On Wed, Sep 8, 2021 at 11:08 PM David Hoffer <dhof...@gmail.com> wrote:

Yes its coming from configuration but ours not Quarkus, we maintain deployment/runtime configs in Zookeeper so all nodes get updated in realtime.

Yes creating the REST Client programmatically is what I need here but it seems there is a problem with it reading path params.  Actually two separate problems.

Problem 1:

@Path("{currentUserId}/{fileName}")

Response sendFile( String currentUserId,

                   String fileName,

   @BeanParam() MultipartBody body);

Here it thinks I have no path variables but from the docs my understanding is that if my variable name matches the Path annotation name then I don't need to annotate with @PathParam.

That is only true for the reactive REST Client (which is based on RESTEasy Reactive code that has this facility).

Problem 2:

@Path("{currentUserId}/{fileName}")

Response sendFile( @PathParam(value = "currentUserId") String currentUserId,

                   @PathParam(value = "fileName") String fileName,

   @BeanParam() MultipartBody body);

Here I go ahead and add @PathParam to solve the prior problem but it still fails because the QuarkusRestClientBuilder#verifyInterface method only files one path variable in @Path.  It only files the last one (fileName)

I don't know about this one. @Michal Szynkiewicz can likely shine some light on this.

Have I defined this incorrectly?

-Dave

On Wednesday, September 8, 2021 at 10:48:01 AM UTC-6 gand...@redhat.com wrote:

On Wed, Sep 8, 2021 at 7:22 PM David Hoffer <dhof...@gmail.com> wrote:

I'm following the following guides regarding having Quarkus mange our REST clients.

https://quarkus.io/guides/rest-client

https://quarkus.io/guides/rest-client-multipart

However the examples show the Path to be provided either in code/annotations and/or in Quarkus application.properties.  In our case the base path is provided by our configuration not Quarkus as it depends on the install network/etc configs.  

How can we use Quarkus to manage the client when the path is a variable from our configs?

You mean that variable is not coming from configuration?

In any case, one can use the REST Client programmatically as shown at: https://quarkus.io/guides/rest-client-reactive#programmatic-client-creation-with-restclientbuilder (the section is in the Reactive REST Client guide, but the feature is actually a MicroProfile REST Client feature, so it works for both the reactive and non-reactive clients)

-Dave

--
You received this message because you are subscribed to the Google Groups "Quarkus Development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to quarkus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/f8fa0a06-e6a2-4762-b9b8-6ba8093541c0n%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Quarkus Development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to quarkus-dev...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/7732fef1-32fd-429a-85cc-2314e920c3cdn%40googlegroups.com.

[David Hoffer]

Btw, I'm using 2.1.4.Final

[David Hoffer]

The problem seems to be here (well actually prior to here):

@Override
public List<String> getPathParamNamesInDeclarationOrder()
{
List<String> params = new ArrayList<String>();
HashSet<String> set = new HashSet<String>();
if (scheme != null) addToPathParamList(params, set, scheme);
if (userInfo != null) addToPathParamList(params, set, userInfo);
if (host != null) addToPathParamList(params, set, host);
if (path != null) addToPathParamList(params, set, path);
if (query != null) addToPathParamList(params, set, query);
if (fragment != null) addToPathParamList(params, set, fragment);

return params;
}

The problem is that the 'path' instance variable is incorrect.  It just has the last of the path variables.

[Georgios Andrianakis]

Please open an issue

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/f918d2d9-1ae1-48d4-af4a-b07156d09a17n%40googlegroups.com.

[Michał Szynkiewicz]

czw., 9 wrz 2021 o 06:49 Georgios Andrianakis <gand...@redhat.com> napisał(a):

Please open an issue

+1, with a minimal reproducer, please : ) 

Also, have you tried rest-client-reactive?

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/CALeTM-mCYUH8bWrRT%2B6Q08gYpr1ByfCwTF16gqHq7i_JW_wrnQ%40mail.gmail.com.

[David Hoffer]

I created https://github.com/quarkusio/quarkus/issues/20069