opentracing with traceId and spanId in log lines

[Jimmy Falkbjer]

Hi,

I added the opentracing extension to my Quarkus application and it all works great with Jaeger.

But when it comes to my log lines I'm not able to get the traceId and spanId. The MDC is empty.

Is this expected and not part of the opentracing extension?

I'm coming from a SpringBoot environment and I'm trying to mimic what I get there, like:

2019-11-10 18:15:35.134 DEBUG [-,fc22278bf95669fc2146348259d7ffd7,c6d486b76d409b25,true] 58569 --- [nio-8082-exec-1] .s.r.a.SomeClass : some message

So basically what I want to configure is something like:

quarkus.log.console.format=%d{yyyy-MM-dd HH:mm:ss.SSS} %5p [-,%X{X-B3-TraceId:-},%X{X-B3-SpanId:-},%X{X-Span-Export:-}] %i --- [%15.15t] %c{2.} : %s%e%n

Anyone has some information to share?

Thanks!

Br

Jimmy

[Pavol Loffay]

Hi Jimmy,

I have submitted PR https://github.com/quarkusio/quarkus/pull/6274 that adds this capability to Quarkus via Jaeger extension. 

If you have any feedback please comment on the PR.

Regards,

[Pavol Loffay]

If there is interest we can add baggage/distributed context into MDC in the next iteration. Let us know if this feature is something you are also interested in.

[Jimmy Falkbjer]

Hi Pavol,

That is great news!

Unfortunately I'm on vacation, without computer, so I'll have to wait until the 27th to try it out.

But now I have something to look forward to when getting home again.

Thanks again!

Br

Jimmy

[Jimmy Falkbjer]

Hi,

We are not using the baggage/distributed context today, so no rush on my behalf.
Thanks for asking.

Br

Jimmy

[Ibrahim abed al aziz]

I am trying to do the same functionality with Quarkus 1.2.1.final version. I've added property "quarkus.jaeger.log-trace-context=true" in my application.properties and tried the below format :

quarkus.log.console.format=%d{yyyy-MM-dd HH:mm:ss.SSS} %5p [-,%X{traceId:-},%X{spanId:-},%X{sampled:-}] %i --- [%15.15t] %c{2.} : %s%e%n

but it didn't work. What i am missing here ?

[Jimmy Falkbjer]

I'm using the syntax below, and it works for me:

quarkus.log.console.format=%d{yyyy-MM-dd HH:mm:ss.SSS} %5p [%X{traceId},%X{spanId},%X{sampled}] %i --- [%15.15t] %c{2.} : %s%e%n

You see that I have removed :- from the syntax compared with yours.

Hope that work for you.

Br

Jimmy

[Jimmy Falkbjer]

Note that I also specify this property:

quarkus.jaeger.propagation=b3

Value can also be jaeger.

/Jimmy

[Ibrahim abed al aziz]

What is the difference between b3 and Jaeger values?

[Jimmy Falkbjer]

It is different formats to achieve distributed tracing.

b3 i is the Zipkin format. Read about it here:

https://github.com/openzipkin/b3-propagation

And jaeger is using the OpenTracing format.

https://opentracing.io/specification/

Note that Jaeger can manage both formats.

Br

Jimmy

[Emmanuel Bernard]

Hey Pavol, probably a thread you want to keep a eye on (for doc or code improvement)

--
You received this message because you are subscribed to the Google Groups "Quarkus Development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to quarkus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/32e11562-1e3e-4509-beb6-af0812363db2%40googlegroups.com.

[Pavol Loffay]

Hi Emmanuel,

any suggestion where "trace" MDC should be documented? 

A couple of notes:

* B3 and Jaeger and context propagation formats. These formats are used to encode/decode trace IDs sent on the wire(between services).  For instance Istio uses B3, therefore all deployments should agree on this protocol. 

* The context propagation formats are usually pluggable.

* Context propagation format does not have any effect on the MDC logging.

--

Pavol Loffay

Senior Software Engineer

M: +41791562647    

[Emmanuel Bernard]

I'd say here

https://quarkus.io/guides/opentracing

source here https://github.com/quarkusio/quarkus/blob/master/docs/src/main/asciidoc/opentracing.adoc

[Pavol Loffay]

Thanks, I will submit a PR shortly. 

[Pavol Loffay]

Here is the PR to docs https://github.com/quarkusio/quarkus/pull/7728 and to the example app https://github.com/quarkusio/quarkus-quickstarts/pull/485