MP Rest client configuration change - looking for feedback

[Tomas Hofman]

Hello,

I have a PR open [1] which exposes these additional configuration properties to an MP rest client interface:

* connectionTTL

* maxPooledPerRoute

* connectionCheckoutTimeout

* connectionPoolSize

These new properties are resteasy implementation specific, not defined by an MP spec.

Originally I exposed them under the same namespace which the MP specific configuration uses, which would be:

* org.acme.rest.client.CountriesService/mp-rest/connectionTTL

* org.acme.rest.client.CountriesService/mp-rest/maxPooledPerRoute

* org.acme.rest.client.CountriesService/mp-rest/connectionCheckoutTimeout

* org.acme.rest.client.CountriesService/mp-rest/connectionPoolSize

but a concern was raised that we shouldn't mix MP specific and implementation specific config under the "mp-rest" namespace.

Another proposal was to have a "quarkus" namespace, like:

org.acme.rest.client.CountriesService/quarkus/connectionTTL

etc.

which would coexist with the "mp-rest" namespace and would expose either all configuration (MP spec + quarkus specific) or just the quarkus specific config.

Anyone have any preferences or different ideas?

[1] https://github.com/quarkusio/quarkus/pull/17220

[Stuart Douglas]

On Mon, 7 Jun 2021 at 20:46, Tomas Hofman <tho...@redhat.com> wrote:

Hello,

I have a PR open [1] which exposes these additional configuration properties to an MP rest client interface:

* connectionTTL

* maxPooledPerRoute

* connectionCheckoutTimeout

* connectionPoolSize

These new properties are resteasy implementation specific, not defined by an MP spec.

Originally I exposed them under the same namespace which the MP specific configuration uses, which would be:

* org.acme.rest.client.CountriesService/mp-rest/connectionTTL

* org.acme.rest.client.CountriesService/mp-rest/maxPooledPerRoute

* org.acme.rest.client.CountriesService/mp-rest/connectionCheckoutTimeout

* org.acme.rest.client.CountriesService/mp-rest/connectionPoolSize

What about something like:

* org.acme.rest.client.CountriesService/mp-rest/quarkus/connectionTTL

* org.acme.rest.client.CountriesService/mp-rest/quarkus/maxPooledPerRoute

* org.acme.rest.client.CountriesService/mp-rest/quarkus/connectionCheckoutTimeout

* org.acme.rest.client.CountriesService/mp-rest/quarkus/connectionPoolSize

 

This way it is similar to the existing config, but won't conflict with any future properties that may be defined.

Stuart

but a concern was raised that we shouldn't mix MP specific and implementation specific config under the "mp-rest" namespace.

Another proposal was to have a "quarkus" namespace, like:

org.acme.rest.client.CountriesService/quarkus/connectionTTL

etc.

which would coexist with the "mp-rest" namespace and would expose either all configuration (MP spec + quarkus specific) or just the quarkus specific config.

Anyone have any preferences or different ideas?

[1] https://github.com/quarkusio/quarkus/pull/17220

--
You received this message because you are subscribed to the Google Groups "Quarkus Development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to quarkus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/2c549ec2-5927-4c57-b9b4-b237c141d461n%40googlegroups.com.