Dropping quarkus-scala 2 extension

[Guillaume Smet]

Hi,

TLDR: I would like to drop the quarkus-scala extension from the core repository entirely. People interested in Scala should use the quarkus-scala3 extension that is in the Quarkiverse (and contribute to it). Anyone against it?

In ancient times, when we were adding all extensions to the core repository, we added the quarkus-scala extension to it.

This extension targets Scala 2 and we have a Scala 3 extension in the Quarkiverse: https://github.com/quarkiverse/quarkus-scala3 .

We talked a few times about moving it to the Quarkiverse but it didn't happen, mostly because at the time moving an external language out of the core was not really supported (project creation wasn't flexible enough, not sure how it is now).

I had to disable the Scala tests for Java 21 as Java 21 and Scala 2 aren't good friends and I'm wondering if we should drop the quarkus-scala (2) extension from Quarkus. People interested in Scala would have to use the Scala 3 extension that lives in the Quarkiverse (and I created a PR to update the Scala 3 extension to Quarkus 3 just now).

So... anyone against me dropping this extension from the core repo?

Just to be clear, I'm talking about dropping it, not moving it to the Quarkiverse.

Thanks.

--

Guillaume

[George Gastaldi]

Do we have any usage numbers on this extension? 

I’m +1 to drop it from the core if you need a vote :) 

Best Regards,

George Gastaldi

--
You received this message because you are subscribed to the Google Groups "Quarkus Development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to quarkus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/CALt0%2Bo-Ca%3DjrH8e2-zd8hgP2oeBEZXsB55-bUaG-y-%3DxYiU%3Dtg%40mail.gmail.com.

[Marco Bungart]

And a follow-up: is Scala downwards-compatible, i.e. can users switch from the scala2- to the scala3-extension? If so: would it be worth while to provide an openrewrite recipe?

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/9F99047B-068E-41D7-9BEA-695A8B3BE49B%40redhat.com.

[Andy Damevin]

Hey hey,

I need to have a look at what it means codestarts wise, having a new external language is still not supported (https://github.com/quarkusio/quarkus/issues/32903). Maybe replacing the Scala 2 by Scala 3 could be ok. Are the codestarts templates the same for Scala 2 and 3?

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/9F99047B-068E-41D7-9BEA-695A8B3BE49B%40redhat.com.

--

Andy Damevin

[Rostislav Svoboda]

Deprecate it with 3.5.0 platform announce and removal with 3.6.0?

[George Gastaldi]

On 23 Oct 2023, at 11:09, Rostislav Svoboda <rsvo...@redhat.com> wrote:

On 23. 10. 2023, at 15:41, Guillaume Smet <guillau...@gmail.com> wrote:

Just to be clear, I'm talking about dropping it, not moving it to the Quarkiverse.

Deprecate it with 3.5.0 platform announce and removal with 3.6.0?

+1. I had the same idea after sending the first email and created https://github.com/quarkusio/quarkus/pull/36637 for that.

Best Regards,

George Gastaldi

[Georgios Andrianakis]

Definitely+1 on dropping.

We have almost never had anyone complaining on GitHub so I am pretty sure that almost no one uses it

--

You received this message because you are subscribed to the Google Groups "Quarkus Development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to quarkus-dev...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/5F7AD606-7F04-43F3-BD00-EF37F56D65EA%40redhat.com.

[Max Andersen]

Openrewrite does not have scala support. 

I don’t think it’s worth spending time on compared to simply move it to quarkiverse

And let it survive there rather than just nuke it.

About impact on codestarts the issue is that —scala flag won’t have something to work on. 

I’ll get the data on downloads so we can see. I suspect it’s minuscule but let’s see before making a conclusion. 

/max

On 23 Oct 2023, at 16:01, 'Marco Bungart' via Quarkus Development mailing list <quark...@googlegroups.com> wrote:



To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/86051815-75f3-4bd4-bd86-7cc8a246c7ec%40googlemail.com.

<OpenPGP_0x1D62FE7F6FECFBC5.asc>

[Marco Bungart]

I thinks you misunderstood my intention. By "downwards-compatible", I mean "can run with the scala3-extension without code change". If this is the case, then we'd only need to change the dependency in the pom.xml. This should be easy enough.

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/EB6CEA06-9B30-4D7B-871B-A2582526571E%40redhat.com.

[Andy Damevin]

For codestarts, if we remove support for Scala 2, we could:

- Migrate all the scala templates to Scala 3

- Add the scala codestart flag to the Scala 3 extension 

- Remove this flag from the Scala 2 (unless the code is still compatible?)

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/bf1d3643-824d-4ed5-8a19-5e935a210e84%40googlemail.com.

--

Andy Damevin

[Andrea Peruffo]

Having been a long-time Scala user:
- dropping Scala 2 support means excluding the majority of the industry use cases as most "production" Scala code bases are still on Scala 2 and moving to 3 means a considerable effort (feel free to ask for details)
- leaving Scala 3 to the community seems completely reasonable

if the usage numbers of Scala 2 templates are low enough I'll be in favor of moving it to the community too.

[Bruno Baptista]

Currently, quarkus-scala is used on ~0,09% of the builds with analytics on.

It has very low usage but the scala 3 extension from Quarkiverse has not been tracked yet.

I think Andrea Peruffo's argument makes sense and we should move it to Quarkiverse. 

Bruno

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/9fa3a7f2-f3e8-42e6-ad57-ac4ce21d166an%40googlegroups.com.

--

Bruno Baptista
http://twitter.com/brunobat_

[Holly Cummins]

It’s a shame the naming for these two is a bit overlappy. As a user, I’d have to dig into the docs to know which to choose. Perhaps when we do the move we should rename ’scala’ to ’scala2’. 

It’s also a shame the scala3 extension looks quite so abandoned, but I think we have more pressing fish to fry.

--

Holly Cummins

Senior Principal Quarkus Software Engineer, Java Champion

Red Hat 

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/CADgv5WizZt7XFhrVhVW9_PbMAQthQN6eOLRO_ssHmWoYw3oM9w%40mail.gmail.com.

[Guillaume Smet]

Hey Holly,

As for the name, yes, if we don't drop it, we will rename it. People will have to change the groupId anyway (if they are not using quarkus update) so good time to rename it.

As for Scala 3 being abandoned, we spent some time with George to update it to Quarkus 3 and make it relevant again (it didn't require much effort so thought it would be better to do it before making a move regarding the Scala 2 extension).

--

Guillaume

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/F780A707-1286-4322-B9C0-B3DFED30125B%40redhat.com.