Jackson and SerializationFeature.WRITE_DATES_AS_TIMESTAMPS

[Bernhard Lutzmann]

Hi,

is there a deeper reason why the SerializationFeature WRITE_DATES_AS_TIMESTAMPS is not disabled by default?

Currently, a LocalDate is serialized to an array, e. g. [2021, 2, 13].

With WRITE_DATES_AS_TIMESTAMPS disabled it is a string, e. g. "2021-02-13".

Similar for LocalDateTime.

Furthermore, in Swagger UI the generated "Example Value" is showing a LocalDate as "2021-02-13" even if the actual returned value is an array.

Bernhard

[Ken Yee]

Guessing it's because dates over REST APIs should be ISO8601 formatted...

--
You received this message because you are subscribed to the Google Groups "Quarkus Development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to quarkus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/8b513194-80d7-42ec-97ef-0f506beea07an%40googlegroups.com.

[Bernhard Lutzmann]

The point is: currently LocalDate and LocalDateTime are not ISO8601 formatted by default.

I have seen developers (including me) running into this issue more then once. Misleading is also the different format that Swagger shows.

Spring is also disabling SerializationFeature.WRITE_DATES_AS_TIMESTAMPS by default:

https://docs.spring.io/spring-boot/docs/current/reference/html/howto.html#howto-customize-the-jackson-objectmapper

IMHO, it would bringe more "developer joy" if dates/times are formatted this way out-of-the-box.

Cheers,

Bernhard

[Georgios Andrianakis]

I personally think it makes sense.

It would be a breaking change, but I think it's warranted

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/193f7d36-2d22-444e-820d-d37b1fe9682fn%40googlegroups.com.

[Guillaume Smet]

I was replying the same.

I think we could change it as long as we introduce a configuration property similar to what I did here: https://github.com/quarkusio/quarkus/blob/master/extensions/jackson/runtime/src/main/java/io/quarkus/jackson/runtime/JacksonBuildTimeConfig.java#L15

to easily go back to the previous behavior.

I can work on that tomorrow, I need easy things as it's release day! 

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/CALeTM-kOrXVSKSe7Cog2cygXVSyMOLWXnvxjFnfj6Tp9%3D-40oA%40mail.gmail.com.

[Georgios Andrianakis]

On Tue, Feb 16, 2021, 21:36 Guillaume Smet <guillau...@gmail.com> wrote:

I was replying the same.

I think we could change it as long as we introduce a configuration property similar to what I did here: https://github.com/quarkusio/quarkus/blob/master/extensions/jackson/runtime/src/main/java/io/quarkus/jackson/runtime/JacksonBuildTimeConfig.java#L15

to easily go back to the previous behavior.

I can work on that tomorrow, I need easy things as it's release day! 

Cool, ping me for a review then 😉

[Guillaume Smet]

I created a PR here: https://github.com/quarkusio/quarkus/pull/15139 .