Resteasy Vertx - How to use max body size as runtime config?

[Postre mus]

Hello,

When using quarkus-undertow, quarkus.http.limits.max-body-size is a runtime configuration.

In Vert.x, it is a build time configuration, since it is read inside a recorder: https://github.com/quarkusio/quarkus/blob/master/extensions/undertow/runtime/src/main/java/io/quarkus/undertow/runtime/UndertowDeploymentRecorder.java#L368

Was this an intended change in behavior?

Is there any other way to change the max entity size value at runtime?

regards,

Martin Panzer

[Georgios Andrianakis]

On Thu, Jan 16, 2020 at 2:52 PM Postre mus <postre...@gmail.com> wrote:

Hello,

Hi,

 

When using quarkus-undertow, quarkus.http.limits.max-body-size is a runtime configuration.

In Vert.x, it is a build time configuration, since it is read inside a recorder: https://github.com/quarkusio/quarkus/blob/master/extensions/undertow/runtime/src/main/java/io/quarkus/undertow/runtime/UndertowDeploymentRecorder.java#L368

The fact that a piece of configuration is used inside a recorder doesn't make it a build time.  The configuration system interacts properly with the recorder infrastructure with runtime configurations as well.

Was this an intended change in behavior?

Is there any other way to change the max entity size value at runtime?

HttpConfiguration (which contains ServerLimitsConfig limits) should be usable at runtime just as any other runtime configuration value.

 

regards,

Martin Panzer

--
You received this message because you are subscribed to the Google Groups "Quarkus Development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to quarkus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/763113ba-0e44-4a4b-bcfc-ca86374e43cb%40googlegroups.com.

[Postre mus]

Thank you Georgios for the answer.

I tested further with my application.

I am currently not able to use "quarkus.http.limits.max-body-size" at all anymore with resteasy vertx.

When I upload a file (multipart/formdata) which is bigger in size then the maximum configured, I still get a 200 OK.

With undertow, I get a "413 Request Entity to large" - as expected.

This happens with Quarkus 1.0.1.Final and 1.1.1.Final.

Installed features: [cdi, hibernate-validator, resteasy, resteasy-jackson, scheduler, smallrye-health, smallrye-openapi, swagger-ui]

[Georgios Andrianakis]

On Thu, Jan 16, 2020 at 4:31 PM Postre mus <postre...@gmail.com> wrote:

Thank you Georgios for the answer.

I tested further with my application.

I am currently not able to use "quarkus.http.limits.max-body-size" at all anymore with resteasy vertx.

When I upload a file (multipart/formdata) which is bigger in size then the maximum configured, I still get a 200 OK.

With undertow, I get a "413 Request Entity to large" - as expected.

This happens with Quarkus 1.0.1.Final and 1.1.1.Final.

Installed features: [cdi, hibernate-validator, resteasy, resteasy-jackson, scheduler, smallrye-health, smallrye-openapi, swagger-ui]

Sounds like a genuine problem. Can you open an issue on Github please with this information?

Thanks

Am Donnerstag, 16. Januar 2020 13:52:48 UTC+1 schrieb Postre mus:

Hello,

When using quarkus-undertow, quarkus.http.limits.max-body-size is a runtime configuration.

In Vert.x, it is a build time configuration, since it is read inside a recorder: https://github.com/quarkusio/quarkus/blob/master/extensions/undertow/runtime/src/main/java/io/quarkus/undertow/runtime/UndertowDeploymentRecorder.java#L368

Was this an intended change in behavior?

Is there any other way to change the max entity size value at runtime?

regards,

Martin Panzer

--

You received this message because you are subscribed to the Google Groups "Quarkus Development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to quarkus-dev...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/26589450-dbbe-45a7-9bd6-a3083b53a8b0%40googlegroups.com.

[Postre mus]

done 

https://github.com/quarkusio/quarkus/issues/6590

Am Donnerstag, 16. Januar 2020 13:52:48 UTC+1 schrieb Postre mus: