[PATCH] Do not show pop-up notification on connection error

10 views
Skip to first unread message

Peter Ujfalusi

unread,
Nov 24, 2012, 12:22:37 PM11/24/12
to vok...@gmail.com, qmpdc...@googlegroups.com, Peter Ujfalusi
When the remote mpd server is not running do not pop up a notification
saying "connection timeout" over and over again.
Updating the tray icon is enough to give feedback to user about lost
connection.

Signed-off-by: Peter Ujfalusi <peter.u...@gmail.com>
---
Hi,

I'm running mpd on a server which is not an always on machine. I usually keep
Qmpdclient running on my other PCs. When the server is off I see a pop-up about
"connection timeout" every minute or so which is really annoying in a long term.
I think it is sufficient to just update the tray icon without showing the pop-up
in case when the connection to the server is lost.

Regards,
Peter

src/libmpdclient.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/src/libmpdclient.c b/src/libmpdclient.c
index 567d4bc..c2ff255 100644
--- a/src/libmpdclient.c
+++ b/src/libmpdclient.c
@@ -560,7 +560,6 @@ static void mpd_getNextReturnElement(mpd_Connection * connection) {
}
else if(err<0 && SELECT_ERRNO_IGNORE) continue;
else {
- strcpy(connection->errorStr,"connection timeout");
connection->error = MPD_ERROR_TIMEOUT;
connection->doneProcessing = 1;
connection->doneListOk = 0;
--
1.8.0

Reply all
Reply to author
Forward
0 new messages