Mouse Event Handling fixes

[David Marques]

Hello everyone,

I finally had the time to review my patch and submit it. Follows attached the signed patch.

Hope it helps improving qzion,

David Marques

[Artur Souza(MoRpHeUz)]

Hi David,

On Monday 16 February 2009 22:48:01 David Marques wrote:
> I finally had the time to review my patch and submit it. Follows attached
> the signed patch.

Thanks for that, we really appreciate people contributing to the project.
Regarding the patch, I have some small comments:

1 - Coding style: it seems that you used "tabs" instead of "spaces" and we
prefer the opposite way =). If you want to check more coding style tips and
tricks, checkout this page:
http://dev.openbossa.org/trac/qedje/wiki/CodingStyleCpp

2 - Commit message: it's very important for us that we have proper written
commit messages in order to help following the history of the project. So it
would be really nice if you could write a description of the patch in the
commit message. Important to say that you wrote a proper "subject" (the first
line of the commit message) and also remembered to sign-off the patch! Nice!

> Hope it helps improving qzion,

It will ;)

Cheers,

---------------------------------------------------------------
Artur Duque de Souza
OpenBossa Research Labs
INdT - Instituto Nokia de Tecnologia
---------------------------------------------------------------
Blog: http://labs.morpheuz.eng.br/blog/
GPG: 0xDBEEAAC3 @ wwwkeys.pgp.net
---------------------------------------------------------------

[David Marques]

Hello Again,

Follows attached the new patch with the suggested changes.

Regards,

David Marques

---

From: Artur Souza(MoRpHeUz) <artur...@openbossa.org>
To: qe...@googlegroups.com
Cc: David Marques <dpsma...@yahoo.com>
Sent: Tuesday, February 17, 2009 9:47:16 AM
Subject: Re: [qedje] Mouse Event Handling fixes

Hi David,

On Monday 16 February 2009 22:48:01 David Marques wrote:

> I finally had the time to review my patch and submit it. Follows attached
> the signed patch.

Thanks for that, we really appreciate people contributing to the project.
Regarding the patch, I have some small comments:

1 - Coding style: it seems that you used "tabs" instead of "spaces" and we
prefer the opposite way =). If you want to check more coding style tips and
tricks, checkout this page:
http://dev.openbossa.org/trac/qedje/wiki/CodingStyleCpp

2 - Commit message: it's very important for us that we have proper written
commit messages in order to help following the history of the project. So it
would be really nice if you could write a description of the patch in the
commit message. Important to say that you wrote a proper "subject" (the first
line of the commit message) and also remembered to sign-off the patch! Nice!

> Hope it helps improving qzion,