New qignore dialog

1 view
Skip to first unread message

Alexander Belchenko

unread,
Feb 19, 2012, 7:00:01 PM2/19/12
to qb...@googlegroups.com
Hi all,

I've just landed new qignore dialog to lp:qbzr/0.22 branch, and I'm
going to release it soon, right before bzr 2.5 final. I hope we have a
little time to test it. My plan is to hook it into bzr-explorer as well.

I've attached a screenshot so you can get an idea how it looks like.

I'd like to ask QBzr users and developers to try it out in next few
days and report any problems you might find.

Thank you.

--
All the dude wanted was his rug back

qignore.PNG

Martin Pool

unread,
Feb 19, 2012, 8:27:45 PM2/19/12
to qb...@googlegroups.com
That looks nice. My main comment is it could be good to see this
integrated with `bzr ignored` so people can see the things they've
previously ignored.
--
Martin

Alexander Belchenko

unread,
Feb 20, 2012, 1:12:53 AM2/20/12
to qb...@googlegroups.com
Martin Pool пишет:

> That looks nice. My main comment is it could be good to see this
> integrated with `bzr ignored` so people can see the things they've
> previously ignored.

I'm not quite understand you.

The dialog shows only unknown files/directories, but not the items
that already ignored. It will complicate the things, because I don't
want to implement the feature: oh, "I've got that file ignored before,
make it unignored now", because there is no support in bzrlib to
remove items from existing ignore list. Also, some items could be
ignored by run-time ignore patterns.

The dialog is a bit simplified to cover most usual need for ignore (as
I see them from my own experience): ignore by pattern
(case-insensitive patterns are important for windows users), ignore by
name. There could be more options, like "ignore all files with this
extension in that directory" but it will make the dialog more crowded,
so I've explicitly dropped that. It already has 5 choices, which is a
bit big for me, but I can live with that.

Thank you for feedback!

Martin Pool

unread,
Feb 20, 2012, 1:19:45 AM2/20/12
to qb...@googlegroups.com
On 20 February 2012 17:12, Alexander Belchenko <bia...@ukr.net> wrote:
>
>
> The dialog shows only unknown files/directories, but not the items that
> already ignored. It will complicate the things, because I don't want to
> implement the feature: oh, "I've got that file ignored before, make it
> unignored now", because there is no support in bzrlib to remove items from
> existing ignore list. Also, some items could be ignored by run-time ignore
> patterns.

Yes, that's what I'm thinking of, but you're right it would need new
bzr support, and would make the UI more complicated. (Arguably, it
makes the overall UI less complicated, if users don't need to look
elsewhere to see what they originally ignored or to change their mind,
but that could wait until later.)

--
Martin

Alexander Belchenko

unread,
Feb 20, 2012, 2:13:25 AM2/20/12
to qb...@googlegroups.com
Martin Pool пишет:

Right.

Alexander Belchenko

unread,
Feb 20, 2012, 2:14:40 AM2/20/12
to qb...@googlegroups.com
Alexander Belchenko пишет:

> My plan is to hook it into bzr-explorer as well.

Already done in bzr-explorer trunk. Time to test it!

Reply all
Reply to author
Forward
0 new messages