DayNightCompositor not applying enhancements when day_only flag is used

[Fabio Mingione]

Good afternoon,

I'm trying to save a Severe Storms RGB with FCI L1C data and force it to work only during the day by using the day_night: day_only flag.

The problem is that when the resampled scene is covered by both day and night, the enhancement is applied correctly (RGB_Convection_Europe*.jpg), while when the scene is in full daylight, no enhancement is applied (RGB_Convection_Italy*.jpg).

I've included the composite and enhancement configs I'm using as an attachment. 

I tried adding a sunz_corrected modified to the blue channels but nothing changes.

Let me also point out that I'm using Satpy version 0.41.1.

Any help would be greatly appreciated.

Kind regards,

Fabio

[David Hoese]

Hi Fabio,

Thanks for reaching out. That version of Satpy is very old and was released in March of 2023. While I don't know off the top of my head if the issue you describe has been fixed in newer versions of Satpy, I don't think we'll be able to properly debug this until you try with the latest release of Satpy (0.53.0). If you are able to upgrade and re-test your use case, please let us know how it goes.

Dave

--
You received this message because you are subscribed to the Google Groups "pytroll" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pytroll+u...@googlegroups.com.
To view this discussion, visit https://groups.google.com/d/msgid/pytroll/e8e9a1c6-8b09-4632-b06d-713701184756n%40googlegroups.com.

[Fabio Mingione]

Hi David,

Thanks a lot for your quick reply.

Sure, I understand. We're indeed planning to upgrade to Satpy 0.53.0 shortly.

I'll let you know how it goes.

Fabio

You received this message because you are subscribed to a topic in the Google Groups "pytroll" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/pytroll/4fVmeev7KCU/unsubscribe.
To unsubscribe from this group and all its topics, send an email to pytroll+u...@googlegroups.com.
To view this discussion, visit https://groups.google.com/d/msgid/pytroll/CAJccSQ_Rv3KMVPtK9ohp200U5PwyUHBOhc03rmPkTw2Mdrk4CQ%40mail.gmail.com.

[Fabio Mingione]

Hi Dave,

I managed to retest my use case with Satpy 0.53.0.

The output images look exactly the same as the ones I attached in my previous email.

Thanks,

Fabio

[David Hoese]

Thanks for trying Fabio. I'll try reproducing with ABI data which I have easier access to. Could you provide me with a minimal version of your code that reproduces the issue? I can guess what it looks like but I want to be sure that we're running the same code.

Dave

To view this discussion, visit https://groups.google.com/d/msgid/pytroll/a749d439-643c-47aa-8045-0b2d90d3ad6en%40googlegroups.com.

[David Hoese]

Fabio,

Are you sure your "Italy" image is correct for this RGB recipe? Everything I'm seeing for "quick guides" both from EUMETSAT and NASA/CIRA (for ABI) look more like your second image. I think the reason for the difference is that your missing an enhancement for the DayNightCompositor composite. It should look something like this:

```

  convection_dayonly:
    standard_name: convection_dayonly
    operations: []

```

This basically says "Don't try to do any more enhancements on this product. It is fine the way it is". The default in Satpy is to take the min/max of the data and linear scale it between those limits. Even for my simple ABI test case which included night data I saw a difference in the "brightness" of the image with and without this included in the enhancement YAML. Additionally, check your indentation of YAML. I think it is inconsistent and uses 3 spaces for the first indentation and 2 spaces for the second indentation. It could have just been my editor messing things up, but it would be better to have things be consistent and cause less issues for any later modifications.

Dave

[Fabio Mingione]

Hi Dave,

Yes, you're correct, "Italy" looks wrong. I wanted it to look exactly like it looks on the "Europe" image.

After the additional enhancement you suggested, they look exactly the same, as I wanted.

Thanks a lot!

Fabio