kazoo patch to workaround select's file descriptor limitation

[pat...@dropbox.com]

Hey guys,

I wrote a patch to deal with the fact that select cannot handle file descriptors larger than 1024.  What is the best way to upstream this change?  (patch: https://www.dropbox.com/s/9dae2bfk1jfilwr/kazoo-1.3.1.patch)

Thanks,

Patrick

[Hanno Schlichting]

Hey,

 

On Thu, Feb 27, 2014, at 1:55, pat...@dropbox.com wrote:

I wrote a patch to deal with the fact that select cannot handle file descriptors larger than 1024.  What is the best way to upstream this change?  (patch: https://www.dropbox.com/s/9dae2bfk1jfilwr/kazoo-1.3.1.patch)

 

best approach would be a pull request on github. Second best choice is opening an issue on github and attaching / linking the patch there.

 

It would also help if you could provide some more details on the environment in which you encountered this problem. Is this specifc to some OS / distros? Does it apply to both Linux/Windows? In which situation do you encounter so many file descriptors, maybe there's something else wrong that leaks FD's or uses too many of them. In any case it would be good to have some short notes on these questions on github, so someone else can later find it and figure out the reason for the patch.

 

Cheers,

Hanno

[pat...@dropbox.com]

This patch only applies to posix based systems (Windows does not support epoll; I guess we should condition this to use regular select in windows).  This problem is common to most posix select implementations.  We're not leaking file descriptors; Dropbox servers regularly have thousands of open file descriptors.