[Fwd: Re: Some fixes to polib]

0 views
Skip to first unread message

David Jean Louis

unread,
Dec 11, 2007, 4:46:33 AM12/11/07
to python...@googlegroups.com
I am moving this to the ML, for the record.


polib.diff
test_polib.py

izim...@gmail.com

unread,
Dec 11, 2007, 4:54:55 AM12/11/07
to python-polib
Anders,

> A colleague of mine did a more thorough escape/unescape
> implementation and some minor fixes:
>
> 1) escape/unescape according to gettext
> 2) proper handling of multiline strings, particularly in metadata
> entries
>

The patch works great for me, all the tests passes, thanks !

One note: I think the _quote and _unquote_msg methods should be
replaced by functions (_quote/_unquote with the corresponding
docstrings and doctests), do you have time to do this ? If not I will
do it asap.

David Jean Louis

unread,
Dec 11, 2007, 5:38:28 AM12/11/07
to python...@googlegroups.com, Anders Quist

> The patch works great for me, all the tests passes, thanks !
>
> One note: I think the _quote and _unquote_msg methods should be
> replaced by functions (_quote/_unquote with the corresponding
> docstrings and doctests), do you have time to do this ? If not I will
> do it asap

Finally I found some time and modified the patch, attached the new patch.
I'll commit it today.

polib.diff
Reply all
Reply to author
Forward
0 new messages