Random data file in the source package

24 views
Skip to first unread message

Elena ``of Valhalla''

unread,
Feb 28, 2012, 10:19:03 AM2/28/12
to python...@googlegroups.com
Hello

I'm trying to get python-gpg packaged in debian and there
have been some doubts about the random_binary_data file
in the source tarball: I've seen that it is used by the
test suite, but it isn't clear why it has to be 5MB in size,
way more than the full package.

Could it be substituted with a smaller file, or even generated
from scratch at the start of the (first?) test run?

thanks in advance
--
Elena ``of Valhalla''

signature.asc

Vinay Sajip

unread,
Mar 2, 2012, 12:48:05 PM3/2/12
to python-gnupg
On Feb 28, 3:19 pm, Elena ``of Valhalla'' <elena.valha...@gmail.com>
wrote:

> I'm trying to get python-gpg packaged in debian and there
> have been some doubts about the random_binary_data file
> in the source tarball: I've seen that it is used by the
> test suite, but it isn't clear why it has to be 5MB in size,
> way more than the full package.
>
> Could it be substituted with a smaller file, or even generated
> from scratch at the start of the (first?) test run?

I wanted to test with a file which was non-trivial in size (for
testing buffering etc.) but it's perfectly OK to generate from scratch
when it's needed. IIRC I just called os.urandom() and saved that.

I will change in the next release to not ship the file with the
tarball, but generate it anew in the test if nonexistent.

Regards,

Vinay Sajip
Reply all
Reply to author
Forward
0 new messages