Comment on revision r31881d2201f378e68a1c839aec9a40524c2cfa48 in pysph

2 views
Skip to first unread message

py...@googlecode.com

unread,
May 11, 2011, 12:43:29 AM5/11/11
to pysp...@googlegroups.com
Comment by prabhu.r...@gmail.com:

Score: Positive

General Comment:
Awesome, looking forward to using this. Please make the minor changes I
suggest below.

Line-by-line comments:

File: /source/pysph/base/linked_list.py
(r31881d2201f378e68a1c839aec9a40524c2cfa48)
===============================================================================

Line 11: class LinkedListManager:
-------------------------------------------------------------------------------
Please make this a new style class by subclassing object. class
LLM(object).
File: /source/pysph/base/locator.py
(r31881d2201f378e68a1c839aec9a40524c2cfa48)
===============================================================================

Line 4: class LinkedListSPHNeighborLocator:
-------------------------------------------------------------------------------
Again make this a subclass of object.

For more information:
http://code.google.com/p/pysph/source/detail?r=31881d2201f378e68a1c839aec9a40524c2cfa48

Reply all
Reply to author
Forward
0 new messages