Comment on revision rb9e6145950e13450e69e0954bcbb4d7bcdd70ff4 in pysph

[py...@googlecode.com]

Comment by prabhu.r...@gmail.com:

Score: Positive

Line-by-line comments:

File: /examples/dam-break/dam_break.py
(rb9e6145950e13450e69e0954bcbb4d7bcdd70ff4)
===============================================================================

Line 84: from pysph.tools import geometry_utils as geom
-------------------------------------------------------------------------------
I think you can call the geometry_utils as geometry to save some pain.
Rather than importing it "as" geom everytime.
File: /examples/dam-break/dam_break3d.py
(rb9e6145950e13450e69e0954bcbb4d7bcdd70ff4)
===============================================================================

Line 173: """
-------------------------------------------------------------------------------
Don't you have some of the others implemented now?
File: /source/pysph/tools/geometry_utils.py
(rb9e6145950e13450e69e0954bcbb4d7bcdd70ff4)
===============================================================================

Line 15: | /
-------------------------------------------------------------------------------
Is the z-axis out of the plane, for if it is not, then this isn't properly
right handed. :)

For more information:
http://code.google.com/p/pysph/source/detail?r=b9e6145950e13450e69e0954bcbb4d7bcdd70ff4