Comment on revision r1343fb87489604162cb04f32ac6a241d6a60d2f5 in pysph
py...@googlecode.com
Score: Neutral
General Comment:
Interesting, but I think we should discuss these changes a little before
checking them in. It would be a good idea to do this on a separate branch
rather than in the current repository.
Line-by-line comments:
File: /source/pysph/solver/solver.py
(r1343fb87489604162cb04f32ac6a241d6a60d2f5)
===============================================================================
Line 16: HAS_CL = True
-------------------------------------------------------------------------------
Can't this be simply imported from utils rather than done again and again?
File: /source/pysph/sph/sph_calc.pyx
(r1343fb87489604162cb04f32ac6a241d6a60d2f5)
===============================================================================
Line 189: #raise RuntimeWarning, "Kernel file does not exist!"
-------------------------------------------------------------------------------
Why aren't you raising the error here? I think the cl files should be in a
separate directory and not with the other pyx files.
For more information:
http://code.google.com/p/pysph/source/detail?r=1343fb87489604162cb04f32ac6a241d6a60d2f5