Comment on revision r6ff1115d9bd9011426da74a55de6d1d227e69191 in pysph

2 views
Skip to first unread message

py...@googlecode.com

unread,
May 5, 2011, 4:07:17 AM5/5/11
to pysp...@googlegroups.com
Comment by prabhu.r...@gmail.com:

Score: Positive

General Comment:
Nice. Does this also fix the issue with it building both c++ and c sources?

For more information:
http://code.google.com/p/pysph/source/detail?r=6ff1115d9bd9011426da74a55de6d1d227e69191

py...@googlecode.com

unread,
May 5, 2011, 5:52:49 AM5/5/11
to pysp...@googlegroups.com
Comment by pankaj86:

General Comment:
yes, that issue was due to makefile still building c files.
Now make simply calls 'setup.py build_ext --inplace' by default
Annotated html files are not generated by default now, 'make annotate'
needs to be called explicitly

Reply all
Reply to author
Forward
0 new messages