Comment on revision r0979740f53270ef2c6cad454d980da5b6b5f3bab in pysph

[py...@googlecode.com]

Comment by prabhu.r...@gmail.com:

Line-by-line comments:

File: /source/pysph/base/domain_manager.py
(r0979740f53270ef2c6cad454d980da5b6b5f3bab)
===============================================================================

Line 589:
hostbuf=self.cellids[pa.name])
-------------------------------------------------------------------------------
You should really abstract this function out into cl_utils and do a version
specific function call from there. This would let pysph work with either
pyopencl from trunk or the latest release.
File: /source/pysph/base/particle_array.pyx
(r0979740f53270ef2c6cad454d980da5b6b5f3bab)
===============================================================================

Line 1282: cl.enqueue_read_buffer(self.queue,
-------------------------------------------------------------------------------
Same here, if we have one function to take care of this we shouldn't have
to worry about pyopencl version issues.

For more information:
http://code.google.com/p/pysph/source/detail?r=0979740f53270ef2c6cad454d980da5b6b5f3bab