Comment on revision r048450fea2c248880a082f4b595032dbee4b060c in pysph
py...@googlecode.com
Line-by-line comments:
File: /source/pysph/base/domain_manager.py
(r048450fea2c248880a082f4b595032dbee4b060c)
===============================================================================
Line 229: self._current_cell = 0
-------------------------------------------------------------------------------
This looks dangerous, it would mean that the iterator is not re-entrant,
i.e. you cannot have two threads iterating on this. This would also
potentially be slow since you are iterating over lists. These are things
to think about and also keep in mind. This is elegant but I am not sure
about the performance of this in Cython. Might be worth testing the
performance.
For more information:
http://code.google.com/p/pysph/source/detail?r=048450fea2c248880a082f4b595032dbee4b060c