Comment on revision r66cbcf0b90b9487ba27c4e532d7dd0269324229b in pysph

[py...@googlecode.com]

Comment by prabhu.r...@gmail.com:

Score: Neutral

Line-by-line comments:

File: /source/pysph/base/locator.py
(r66cbcf0b90b9487ba27c4e532d7dd0269324229b)
===============================================================================

Line 86: for (int iz = idz-2; iz <= idz+2; ++iz)
-------------------------------------------------------------------------------
Is this really needed? You are increasing the number of neighboring cells
by a factor of 8 if you do this. This will considerably slow things down.

For more information:
http://code.google.com/p/pysph/source/detail?r=66cbcf0b90b9487ba27c4e532d7dd0269324229b