latest pubsub update, and monitor.py

19 views
Skip to first unread message

Oliver

unread,
Aug 11, 2013, 1:02:00 AM8/11/13
to pypu...@googlegroups.com
Hi Josh, just wanted to let you know that I tentatively incorporated XmlTopicDefnProvider in pubsub.utils. It required the following: 
  • I had to edit the three files a bit to make consistent with pubsub API. For instance, 
    • I want to avoid multiple ways of doing same thing, so there is no longer an importTopicTree, everything is done via addTopicDefnProvider (see examples folder). So no importTopicTreeXml either; I've changed the docs/tests accordingly. 
    • I've renamed exportXMLTopicTree to exportTopicTreeSpecXml so it has clear relationship to exportTopicTreeSpec. 
    • Converted tests to use nose.  
  • I need to have copyright of all code in pubsub folder (for obvious reasons). I put your name as author in src/pubsub/utils/xmltopicdefprovider.py. Please confirm that you are ok with this, and the wording in the docstring of xmltopicdefnprovider. Feel free to submit a patch (on pypubsub_dev rather than on pypubsub, if possible). 
While cleaning up, I noticed a file in src/contrib called monitor.py which you contributed a few years ago, it appears to be a wxPython panel to monitor pubsub messages. Pubsub has changed a fair bit since then, do you have an update? I've callled it wx_monitor.py to make it clear it is wx-specific; you'll find it in SVN. I would like to include it in pubsub.utils if you have an update. 

The upcoming release of pubsub will be 3.2.0. The code is now beta. If you have a minute to checkout the latest version in SVN and try it out, let me know whether anything breaks. The API v3 changes are minor: 
  • pub.getDefaultRootAllTopics -> renamed to pub.getDefaultTopicTreeRoot
  • pub.importTopicTree -> removed, use pub.addTopicDefnProvider(source, format)
  • pub.exportTopicTree -> renamed to pub.exportTopicTreeSpec
Pubsub no longer supports v1 and v2 APIs. 
Oliver

Josh English

unread,
Aug 12, 2013, 3:18:05 PM8/12/13
to pypu...@googlegroups.com

I pulled the SVN, and everything installed just fine. I am scrubbing my code of all the imports. I do not know how to make a patch with SVN, or even how to create a branch, so I'll have to give you these changes manually. (Sorry. This is the part of programming that leaves me a rank amateur.)

In pubsub.utils.xmltopicdefnprovider

line 71: 'importTopicTree' is in the __all__ list and needs to be removed.

and that's all I've found. I didn't see anything in the docs about this tool, either.

I don't have a new wx-monitor worth anything right now.

Josh

> --
> You received this message because you are subscribed to the Google Groups
> "pypubsub" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to pypubsub+u...@googlegroups.com.
> To post to this group, send email to pypu...@googlegroups.com.
> Visit this group at http://groups.google.com/group/pypubsub.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

--
Josh English
Joshua.R...@gmail.com
http://www.joshuarenglish.com

Reply all
Reply to author
Forward
0 new messages