Hi Oliver,
On 13/02/2014 14:22, oliver wrote:
> Hi Werner, I will take a look, but glad you find the fixes necessary.
> I did cleanup the API at the pub level to only leave things that would
> be useful, removing everything that was "expert" level.
Which I think is a good idea.
> I didn't realize you guys had your own set of unit tests, this is a
> lot of duplication of those that pubsub already uses, you sure that's
> necessary?
It would be nice to have just one set. IIRC when I did them for Phoenix
last year I don't think one could have dropped the ones you had just in,
but then I am no expert on this. Maybe take this up with Robin and see
what can be done to have just one set which works for both your testing
setup and the one Robin uses.
Maybe before you spend time reviewing the PR bring it up with Robin on
the wxpyton-dev list, maybe in the thread about the pubsub tests "Re:
[wxPython-dev] Pubsub unittests"
Werner