Jenkins testing and GitHub rate limits

20 views
Skip to first unread message

Siirola, John D

unread,
Sep 5, 2019, 1:57:06 PM9/5/19
to pyomo-de...@googlegroups.com

All,

 

We are hitting an issue where the Jenkins Autotester is hitting the GitHub rate limit.  This causes the autotester to fail.  Previously, the Autotester was checking PRs every 10 minutes.  Due to the number of open PRs, it ended up running nearly continuously.  While we can slow that polling frequency, I suspect that a better policy will be to reduce the number of open PRs that we autotest.

 

Some possible ideas:

  • Do not autotest [WIP] or [IDEA] PRs on Jenkins
  • Close PRs that are *very* stale.  We could flag them with a label so we could find them again (something like “ARCHIVED_UNRESOLVED”).
  • …something else?

 

john

Bynum, Michael Lee

unread,
Sep 5, 2019, 2:06:34 PM9/5/19
to pyomo-de...@googlegroups.com
I am in favor of both of your ideas.

Michael

-- 
You received this message because you are subscribed to the Google Groups "Pyomo Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pyomo-develope...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/pyomo-developers/d9a860b9e83944699b3f370bbc08bf0a%40ES02AMSNLNT.srn.sandia.gov.

Qi Chen

unread,
Sep 5, 2019, 2:12:08 PM9/5/19
to Pyomo Developers
I am perfectly fine with not autotesting [WIP] and [IDEA]. For very stale PRs, is this because the autotester has to go through and check their status? Would it help at all to mark them [STALE] instead of closing?


Am Donnerstag, 5. September 2019 14:06:34 UTC-4 schrieb Michael Bynum:
I am in favor of both of your ideas.

Michael

On Sep 5, 2019, at 11:57 AM, 'Siirola, John D' via Pyomo Developers <pyomo-de...@googlegroups.com> wrote:

All,
 
We are hitting an issue where the Jenkins Autotester is hitting the GitHub rate limit.  This causes the autotester to fail.  Previously, the Autotester was checking PRs every 10 minutes.  Due to the number of open PRs, it ended up running nearly continuously.  While we can slow that polling frequency, I suspect that a better policy will be to reduce the number of open PRs that we autotest.
 
Some possible ideas:
  • Do not autotest [WIP] or [IDEA] PRs on Jenkins
  • Close PRs that are *very* stale.  We could flag them with a label so we could find them again (something like “ARCHIVED_UNRESOLVED”).
  • …something else?
 
john

-- 
You received this message because you are subscribed to the Google Groups "Pyomo Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pyomo-developers+unsub...@googlegroups.com.

David Woodruff

unread,
Sep 5, 2019, 2:15:40 PM9/5/19
to pyomo-de...@googlegroups.com
I am also in favor of both ideas that do not end in a question mark.
  Dave

Siirola, John D

unread,
Sep 5, 2019, 2:26:36 PM9/5/19
to pyomo-de...@googlegroups.com

I like the idea of a [STALE] flag.  That way active WIPs can continue to get Jenkins testing – which is useful, particularly for things like PySP and solver interface PRs, as Jenkins is the only platform with licensed solvers.

 

john

 

From: pyomo-de...@googlegroups.com <pyomo-de...@googlegroups.com> On Behalf Of Qi Chen
Sent: Thursday, September 5, 2019 12:12 PM
To: Pyomo Developers <pyomo-de...@googlegroups.com>
Subject: Re: [EXTERNAL] Jenkins testing and GitHub rate limits

 

I am perfectly fine with not autotesting [WIP] and [IDEA]. For very stale PRs, is this because the autotester has to go through and check their status? Would it help at all to mark them [STALE] instead of closing?

Am Donnerstag, 5. September 2019 14:06:34 UTC-4 schrieb Michael Bynum:

I am in favor of both of your ideas.

 

Michael



On Sep 5, 2019, at 11:57 AM, 'Siirola, John D' via Pyomo Developers <pyomo-de...@googlegroups.com> wrote:

 

All,

 

We are hitting an issue where the Jenkins Autotester is hitting the GitHub rate limit.  This causes the autotester to fail.  Previously, the Autotester was checking PRs every 10 minutes.  Due to the number of open PRs, it ended up running nearly continuously.  While we can slow that polling frequency, I suspect that a better policy will be to reduce the number of open PRs that we autotest.

 

Some possible ideas:

  • Do not autotest [WIP] or [IDEA] PRs on Jenkins
  • Close PRs that are *very* stale.  We could flag them with a label so we could find them again (something like “ARCHIVED_UNRESOLVED”).
  • …something else?

 

john

 

-- 
You received this message because you are subscribed to the Google Groups "Pyomo Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to pyomo-develope...@googlegroups.com.


To view this discussion on the web visit 

You received this message because you are subscribed to the Google Groups "Pyomo Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to pyomo-develope...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/pyomo-developers/0c01729f-55bb-48a6-92f0-e44b83a95789%40googlegroups.com.

William Hart

unread,
Sep 5, 2019, 5:58:38 PM9/5/19
to pyomo-de...@googlegroups.com
I would expect that tests from WIP PRs would be used to guide development, so I'd recommend not omitting these PRs.

Adding a tag like [STALE] sounds excellent.  It has the added benefit of creating social pressure to either complete or delete the PR.

--Bill

--
Reply all
Reply to author
Forward
0 new messages