[Bug 407838] [NEW] lambda expressions do not properly generate closures.

0 views
Skip to first unread message

Bradley M. Kuhn

unread,
Aug 1, 2009, 7:22:19 PM8/1/09
to pynie-dev-ga...@googlegroups.com
Public bug reported:

Lambda expressions currently fail basic closure tests on trunk. The
included patch uses a newclosure Parrot opcode to force creation of a
closure each time the lambda is evaluated, allowing lambda closure to
function properly. This patch causes that part of the functions.py test
to pass now.

** Affects: pynie
Importance: Undecided
Status: New

--
lambda expressions do not properly generate closures.
https://bugs.launchpad.net/bugs/407838
You received this bug notification because you are a member of pynie-
dev, which is the registrant for Pynie.

Status in Pynie - Python on Parrot: New

Bug description:
Lambda expressions currently fail basic closure tests on trunk. The included patch uses a newclosure Parrot opcode to force creation of a closure each time the lambda is evaluated, allowing lambda closure to function properly. This patch causes that part of the functions.py test to pass now.

Bradley M. Kuhn

unread,
Aug 1, 2009, 7:22:19 PM8/1/09
to pynie-dev-ga...@googlegroups.com

** Attachment added: "Lambda closure fix"
http://launchpadlibrarian.net/29784783/pynie_lambda-closures.patch

Bradley M. Kuhn

unread,
Aug 1, 2009, 7:23:18 PM8/1/09
to pynie-dev-ga...@googlegroups.com
BTW, the patch is copyrighted by me and licensed under Artistic-2.0-or-
later.

Bradley M. Kuhn

unread,
Aug 1, 2009, 8:37:57 PM8/1/09
to pynie-dev-ga...@googlegroups.com
Based on discussion with pmichaud, I implemented this as a pirop
instead. Committed to trunk at r80.


** Changed in: pynie
Status: New => Fix Committed

--
lambda expressions do not properly generate closures.
https://bugs.launchpad.net/bugs/407838
You received this bug notification because you are a member of pynie-
dev, which is the registrant for Pynie.

Status in Pynie - Python on Parrot: Fix Committed

Allison Randal

unread,
Aug 10, 2009, 2:19:54 AM8/10/09
to pynie-dev-ga...@googlegroups.com
Bradley M. Kuhn wrote:
> BTW, the patch is copyrighted by me and licensed under Artistic-2.0-or-
> later.

That would mean we can't apply it. Pynie is currently still covered by
the old Perl CLA, and under Artistic 2.0, but it will be switching to
the Python CLA and the Python license in the not-to-distant future. We
have verbal agreement from all existing Pynie contributors to sign a
Python CLA when we reach that point, and would need the same from you.

Allison

--
lambda expressions do not properly generate closures.
https://bugs.launchpad.net/bugs/407838
You received this bug notification because you are a member of pynie-
dev, which is the registrant for Pynie.

Status in Pynie - Python on Parrot: Fix Committed

Allison Randal

unread,
Aug 10, 2009, 3:00:38 AM8/10/09
to pynie-dev-ga...@googlegroups.com
** Changed in: pynie
Status: Fix Committed => Fix Released

--
lambda expressions do not properly generate closures.
https://bugs.launchpad.net/bugs/407838
You received this bug notification because you are a member of pynie-
dev, which is the registrant for Pynie.

Status in Pynie - Python on Parrot: Fix Released

Bradley M. Kuhn

unread,
Aug 10, 2009, 10:41:20 AM8/10/09
to pynie-dev-ga...@googlegroups.com
> Bradley M. Kuhn wrote:
>> BTW, the patch is copyrighted by me and licensed under Artistic-2.0-or-
>> later.

Allison Randal wrote at 02:19 (EDT):

> That would mean we can't apply it. Pynie is currently still covered by
> the old Perl CLA, and under Artistic 2.0, but it will be switching to
> the Python CLA and the Python license in the not-to-distant future. We
> have verbal agreement from all existing Pynie contributors to sign a
> Python CLA when we reach that point, and would need the same from you.

Ok, I didn't realize it, and assumed the project was Artistic-2.0. I'm
sure I can probably sign the Python CLA. I'll read it this weekend and
let you know, but I seriously doubt it will be a problem.

Sorry for the confusion. I had asked pmichaud on IRC and he seemed to
think Artistic-2.0 was right.

(BTW, I've been committing to Pynie already, pmichaud gave me access, so
I will strive to make sure the licensing all gets sorted out. I tend to
like to be explicit about licensing of patches in bug trackers, because
it helps find implicit things -- like this issue of the Python CLA.)


--

-- bkuhn

--
lambda expressions do not properly generate closures.
https://bugs.launchpad.net/bugs/407838
You received this bug notification because you are a member of pynie-
dev, which is the registrant for Pynie.

Status in Pynie - Python on Parrot: Fix Released

Reply all
Reply to author
Forward
0 new messages