Failing test in deform: test_deserialize_file_selected_with_previous_file_IE_whole_path

[Damien Baty]

Hello,

I am getting a failing test in the "master" branch of "deform":

--- 8< ---
FAIL: test_deserialize_file_selected_with_previous_file_IE_whole_path
(deform.tests.test_widget.TestFileUploadWidget)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/damien/dev/deform-upstream/deform/tests/test_widget.py",
line 1052, in
test_deserialize_file_selected_with_previous_file_IE_whole_path
self.assertEqual(result['preview_url'], 'http://localhost/filename')
AssertionError: 'http://localhost/baz.pt' != 'http://localhost/filename'
--- 8< ---

Jenkins gets it too: http://jenkins.pylonsproject.org/job/deform/

The failure seems to come from a bug in the test itself: contrary to
other test methods in this test case, the filename is set to something
other than "filename" so, obviously, we don't get
"http://localhost/filename" as the preview URL.

On the other hand, this test has been failing since June so perhaps it
is intended to exhibit a bug in "deform" (although it does not look like
it). Any idea?

Cheers,

--
Damien Baty

[Chris McDonough]

I see the same failure.

Git blame tells me:

aed3f211 (Tom Lazar 2012-06-18 21:13:18 +0200 1052)

self.assertEqual(result['preview_url'], 'http://localhost/filename')

Not entirely sure what's trying to be tested there, but I just made the
actual result match the expected and now the tests pass.

- C