Issue 26 in pylibnidaqmx: add support for reference triggering

[pylibn...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 26 by tolis...@gmail.com: add support for reference triggering
http://code.google.com/p/pylibnidaqmx/issues/detail?id=26

I don't see support for the reference triggered functions:

DAQmxCfgAnlgEdgeRefTrig()
DAQmxCfgAnlgWindowRefTrig()
DAQmxCfgDigEdgeRefTrig()
DAQmxCfgDigPatternRefTrig()

[pylibn...@googlecode.com]

Comment #1 on issue 26 by tolis...@gmail.com: add support for reference
triggering
http://code.google.com/p/pylibnidaqmx/issues/detail?id=26

I've attached a patch file for these functions (and the disable reference
trigger). However, I have only need for DAQmxCfgDigEdgeRefTrig() at the
moment and it seems my DAQ device doesn't support several of the others, so
I am unable to fully test. But this might be a good enough starting point
for you.

Attachments:
libnidaqmx.py.patch 8.7 KB

[pylibn...@googlecode.com]

Updates:
Status: Fixed

Comment #2 on issue 26 by pearu.peterson: add support for reference
triggering
http://code.google.com/p/pylibnidaqmx/issues/detail?id=26

Thanks for the patch!
I have applied it to svn repo.
PS: patch was not actually a proper one but that's ok.

[pylibn...@googlecode.com]

Comment #3 on issue 26 by labakust...@gmail.com: add support for reference
triggering
http://code.google.com/p/pylibnidaqmx/issues/detail?id=26

I've tested new funcionality on NI USB-4431. The functions
DAQmxCfgDigEdgeRefTrig()
and DAQmxCfgDigPatternRefTrig() are ok, but DAQmxCfgAnlgEdgeRefTrig()
DAQmxCfgAnlgWindowRefTrig() are not working.
When using reference trigger with analog input you don't need prefix '/',
it's required only for digital input. Please observe following diff output.
Do you consider adding support for IEPE sensors?
1563,1564c1563,1565
< if not source.startswith('/'): # source needs to start with a '/'
< source = '/'+source
---
> # if not source.startswith('/'):
> # source needs to start with a '/'
> # source = '/'+source
1622,1623c1623,1625
< if not source.startswith('/'): # source needs to start with a '/'
< source = '/'+source
---
> # if not source.startswith('/'):
> # source needs to start with a '/'
> # source = '/'+source

[pylibn...@googlecode.com]

Comment #4 on issue 26 by pearu.peterson: add support for reference
triggering
http://code.google.com/p/pylibnidaqmx/issues/detail?id=26

Thanks for the feedback! I have applied the corresponding patch to svn.
Regarding support additions, all patches are welcome.