Bug in setup.py?cd -

[Phil Rittenhouse]

I think I found a small bug in setup.py

In r36 of setup.py 'avutil' was added to the libs tuple making the
addition of 'avutil' in line 90 (for windows) redundant

Then in May 19 in Git the libs tuple was changed to a list. This
results in the following error on windows:

Traceback (most recent call last):
File "setup.py", line 90, in <module>
libs = static_resolver(libs + ('avutil',))
TypeError: can only concatenate list (not "tuple") to list


I think the cleanest fix is to simply change the code from

if platform == 'win32':
libs = static_resolver(libs + ('avutil',))
libinc += [ r'/mingw/lib' ] # why my mingw is unable to find
libz2?

to

if platform == 'win32':
libs = static_resolver(libs)
libinc += [ r'/mingw/lib' ] # why my mingw is unable to find
libz2?


Thanks,
Phil

[nouvel]

Hi Phil,

Thanks a lot for this comment, I indeed also need to rework the
setup.py, to make
it cleaner for all the platforms and versions...

Best,
Bertrand


On Jan 7, 12:14 am, Phil Rittenhouse <phil.rittenho...@gmail.com>
wrote: