Fix for cython 0.14, registration problem, and ignore if a track is not found

7 views
Skip to first unread message

Nicolas Boichat

unread,
Jan 9, 2011, 3:22:21 AM1/9/11
to pyffmp...@googlegroups.com
Hi all,

I've been trying to integrate pyffmpeg with impressive
(http://impressive.sf.net), and I've run into a few problems, that I
fixed with the 3 patches below.

fix-cython-0.14.patch:
- Fixes compilation error with cython 0.14 (__new__ is renamed to
__cinit__)

fix-registration.patch:
- I've had problems with pyffmpeg not calling "av_register_all". It is
supposed to be done at library init time, but wasn't done in my case
(this caused the problem I had here:
http://groups.google.com/group/pyffmpeg/browse_frm/thread/c0e7d3125ca0ebc2).
- I tried to fix the problem in a nice way, with a static variable
"registered", but it doesn't seem to work (that may be a cython bug,
IIRC registered is not set to false by default), so basically, I'm
always calling "av_register_all"

ignore-notfound-track.patch:
- Ignores errors if a track is not found. This is useful for videos
files without an audio track.

Thanks,

Best regards,

Nicolas

fix-cython-0.14.patch
fix-registration.patch
ignore-notfound-track.patch

nouvel

unread,
Jan 11, 2011, 9:14:56 AM1/11/11
to pyffmpeg-dev
Hi Nicolas,

Thanks a lot for these interesting bug-fixes/updates.

I will integrate them in the source-tree very soon.
They are many small issues, I have to fix on this project, I hope to I
can get an
updated revision very soon.

By the way, I have used "impressive" before, and I was really happy of
it,
so thanks a lot for it.

Best,

Bertrand

On Jan 9, 5:22 pm, Nicolas Boichat <nico...@boichat.ch> wrote:
> Hi all,
>
> I've been trying to integrate pyffmpeg with impressive
> (http://impressive.sf.net), and I've run into a few problems, that I
> fixed with the 3 patches below.
>
> fix-cython-0.14.patch:
>  - Fixes compilation error with cython 0.14 (__new__ is renamed to
> __cinit__)
>
> fix-registration.patch:
>  - I've had problems with pyffmpeg not calling "av_register_all". It is
> supposed to be done at library init time, but wasn't done in my case
> (this caused the problem I had here:http://groups.google.com/group/pyffmpeg/browse_frm/thread/c0e7d3125ca...).
>  - I tried to fix the problem in a nice way, with a static variable
> "registered", but it doesn't seem to work (that may be a cython bug,
> IIRC registered is not set to false by default), so basically, I'm
> always calling "av_register_all"
>
> ignore-notfound-track.patch:
>  - Ignores errors if a track is not found. This is useful for videos
> files without an audio track.
>
> Thanks,
>
> Best regards,
>
> Nicolas
>
>  fix-cython-0.14.patch
> 1KViewDownload
>
>  fix-registration.patch
> 2KViewDownload
>
>  ignore-notfound-track.patch
> < 1KViewDownload
Reply all
Reply to author
Forward
0 new messages