bug in camera.py (fixed it)

30 views
Skip to first unread message

Malte

unread,
Aug 3, 2010, 3:59:24 AM8/3/10
to pydc1394
Hi,

me again. Fiddling around with the format7 modes, I noticed some
deviation from the other modes. Long story short, line 1087 in
camera.py needs to be changed from:
1086 #delegate this to the shape of the image:
1087 self._shape = [ int(hsize.value) , int(vsize.value) ]

to
1087 self._shape = [ int(vsize.value) , int(hsize.value) ]
.
Otherwise the array/picture in format7 gets messed up. I changed it on
my computer and it fixed this problem. I just don't know how to upload
the change to launchpad. I would appreciate it if someone else could
confirm the fix and upload it to launchpad. :)

Malte

SirVer

unread,
Aug 3, 2010, 9:46:24 AM8/3/10
to pydc1394
Hi Malte,

To which revision of pydc are you refering? In r30 of trunk the line
seems to be correct.

Holger

Malte

unread,
Aug 3, 2010, 10:07:15 AM8/3/10
to pydc1394
Hi,

I might be too new for this stuff... :) I was referring to the code
lp:pydc1394 rev. 27, I guess, there it is still broken. In ~tomio2009/
pydc1394/devel0 it is fixed.
I failed to check if it is already fixed in a different branch.
I hope that explained it a bit.
Malte

SirVer schrieb:
Reply all
Reply to author
Forward
0 new messages