Skip to first unread message
Tommaso Costanzo
Jul 12, 2018, 1:11:13 PM7/12/18
to pycroscopy
How can I request to add my fork/local branch to a new branch of the upstream Pycroscopy?
Suhas Somnath
Jul 12, 2018, 2:03:22 PM7/12/18
to pycroscopy
Pull request from your fork. By default GitHub will want to merge to pycroscopy/master. You should be able to change the destination branch.
Tommaso Costanzo
Jul 12, 2018, 2:13:18 PM7/12/18
to pycroscopy
Yes. My issue was the fact that the branch does not exist yet, so I submitted to master. I think that in the contribution guidelines should be specified a unified way to request the creation of a new branch before a pull request.
pycro...@gmail.com
Jul 12, 2018, 2:28:59 PM7/12/18
to pycroscopy
We will update the documentation. In the event that you need a new branch to be created on pycroscopy, just ask and someone will make a new branch for you.
Tommaso Costanzo
Jul 12, 2018, 3:13:23 PM7/12/18
to pycroscopy
Thank you. I noticed a potential bug that I will check tomorrow, and the fix is very easy so I will just make a pull request to master, but then when I will start to add analysis tools I will contact you to have a new branch.
Reply all
Reply to author
Forward
0 new messages