Issue 936 in pychess: PyChess misinterprets sacrifices

[pyc...@googlecode.com]

Status: New
Owner: ----

New issue 936 by xatrickf...@gmail.com: PyChess misinterprets sacrifices
https://code.google.com/p/pychess/issues/detail?id=936

The comments section is very important for beginners, who view it much
during their games and I feel much attention should be laid on this.
PyChess sometimes, misinterprets a sacrifice.

For example;

1.c4 Nf6 2.Nf3 g6 3.g3 Bg7 4.Bg2 O-O 5.d4 d6 6.Nc3 Nbd7 7.O-O
e5 8.e4 c6 9.h3 Qb6 10.d5 cxd5 11.cxd5 Nc5 12.Ne1 Bd7 13.Nd3
Nxd3 14.Qxd3 Rfc8 15.Rb1 Nh5 16.Be3 Qb4 17.Qe2 Rc4 18.Rfc1
Rac8 19.Kh2 f5 20.exf5 Bxf5 21.Ra1 Nf4

21...Nf4 was a sacrifice but PyChess just says "black moves knight to f4"

Another example:

In this position; r3rk2/pb2bpp1/1n5p/q1pP1B2/1p3B2/5N2/PPQ2PPP/R2R2K1 w

After making the move Bc8 (which is a sacrifice), PyChess still doesn't
call it a sacrifice and says "white moved bishop to c8" - It should
say "White sacrifices material" rather than that.

please fix this.



--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[pyc...@googlecode.com]

Updates:
Status: Accepted
Labels: Type-Defect

Comment #1 on issue 936 by gbtami: PyChess misinterprets sacrifices
https://code.google.com/p/pychess/issues/detail?id=936

(No comment was entered for this change.)

[pyc...@googlecode.com]

Comment #2 on issue 936 by gbtami: PyChess misinterprets sacrifices
https://code.google.com/p/pychess/issues/detail?id=936

Seems the attack_type() in strateval.py comments on capture moves only.
(line #153)

[pyc...@googlecode.com]

Comment #3 on issue 936 by xatrickf...@gmail.com: PyChess misinterprets
sacrifices
https://code.google.com/p/pychess/issues/detail?id=936

Tomas, would it be possible for you to make it comment on non-capture moves
too?

[pyc...@googlecode.com]

Comment #4 on issue 936 by gbtami: PyChess misinterprets sacrifices
https://code.google.com/p/pychess/issues/detail?id=936

Sure. But it takes time.