Comment on revision r70ee9a8ed1086d87f0771d30deffebb6a3b36bad in pychess

0 views
Skip to first unread message

pyc...@googlecode.com

unread,
Apr 4, 2011, 6:53:06 AM4/4/11
to pychess-c...@googlegroups.com
Comment by lobais:

General Comment:
That's a very large changeset. I hope it works :)
Are the classes in gamewidget general enough that you can take them out in
their own modules?

For more information:
http://code.google.com/p/pychess/source/detail?r=70ee9a8ed1086d87f0771d30deffebb6a3b36bad

pyc...@googlecode.com

unread,
Apr 6, 2011, 6:04:34 PM4/6/11
to pychess-c...@googlegroups.com
Comment by mattgatto:

General Comment:
:) I've had this changeset around for about 5 or 6 months now and found and
fixed several bugs so I think it's ready.

You're right. GtkMenuItem, GtkMenuToggleButton, and the MenuItemsDict
should probably go somewhere else. Maybe uistuff.py?

pyc...@googlecode.com

unread,
Apr 7, 2011, 3:14:34 AM4/7/11
to pychess-c...@googlegroups.com
Comment by lobais:

General Comment:
What about lib/widgets/GtkMenuItem.py etc.

pyc...@googlecode.com

unread,
Apr 7, 2011, 3:32:42 AM4/7/11
to pychess-c...@googlegroups.com
Comment by mattgatto:

General Comment:
Hmm, okay. I thought lib/widgets/ was for actual widgets (i.e. classes that
actually subclass Gtk widgets), not widget helper libraries (which is what
these all are, even though the names imply otherwise) like in uistuff.py.
Should uistuff.py be in lib/widgets/ then?

They should probably all go in one file, no? Like
lib/widgets/GtkMenuItems.py

Reply all
Reply to author
Forward
0 new messages