Comment on revision re590e51aa1677b4984a2449b4978fadd04e4f3f9 in pychess

[pyc...@googlecode.com]

Comment by mattgatto:

General Comment:
Have you tested out whether this works with a test case? Because when the
game end comes in, both ICGameModel and ICPlayer will be disconnected from
the boardUpdate signal (in ._disconnect()).

For more information:
https://code.google.com/p/pychess/source/detail?r=e590e51aa1677b4984a2449b4978fadd04e4f3f9

[pyc...@googlecode.com]

Comment by mattgatto:

General Comment:

OK, after looking again and to be more precise, the
ICGameModel._disconnect() method occurs when the gamewidget has been
removed/closed while the game is running. If the game ended normally it
seems like _disconnect() won't run (regardless of whether the gamewidget
gets closed/removed later on), which is probably a bug and would cause
issue 885.

[pyc...@googlecode.com]

Comment by mattgatto:

General Comment:

I think we should create (IC)GameController and move the control logic out
of the models... That way we wouldn't have as many issues like this where
updating the TimeModel is dependent on the state of the GameModel.

Also, what is the reason for this in TimeModel.tap()?
def tap (self):
if self.paused: return

[pyc...@googlecode.com]

Comment by gbtami:

General Comment:
Maybe Thomas knows.