PyChess Code Reviews

Comment by gbtami: General Comment: fixed For more information: https://code.google.com/p/pychess/

Comment by gbtami: General Comment: Fixed, thx! For more information: https://code.google.com/p/

Comment by gbtami: General Comment: Maybe Thomas knows. For more information: https://code.google.com

Comment by gbtami: General Comment: Moved it there, thx! For more information: https://code.google.

Comment by gbtami: General Comment: Done. Thx. Matt! For more information: https://code.google.com/p/

Comment by gbtami: General Comment: If the score diff of two consecutive position is greater than

Comment by gbtami: General Comment: Thx, good to know :) For more information: http://code.google.com

Comment by matt...@gmail.com: General Comment: Do you have an example test case of this? Because I

Comment by gbtami: General Comment: Unfortunately HelperManager has no signals to use with

Comment by matt...@gmail.com: Score: Positive General Comment: I didn't try it with the default

Comment by matt...@gmail.com: General Comment: I'm glad you took care of that bug. I almost

Comment by matt...@gmail.com: Score: Positive General Comment: Awesome! For more information: http:

Comment by gbtami: General Comment: It's better to log as "edit game" instead. For more

Comment by gbtami: General Comment: It was #747 instead. For more information: http://code.google.com

Comment by gbtami: General Comment: removed it For more information: http://code.google.com/p/pychess

Comment by gbtami: General Comment: You have to run pgn2ecodb.sh to create eco.db file. Same for

Comment by lobais: Score: Positive General Comment: That's a weird typo :p For more information:

Comment by gbtami: General Comment: Heh, accidentally committed adding gameno to gamelist as first

Comment by lobais: Score: Positive General Comment: Great fix :) For more information: http://code.

Comment by gbtami: General Comment: The u" here is not needed just for typing these symbols, but

Comment by lobais: Score: Positive General Comment: I'm thinking it's bad if the code starts

Comment by lobais: Score: Positive General Comment: Good fixes. I'm a bit unsure whether it's

Comment by mattgatto: Score: Positive General Comment: Thanks for doing this. I was in the process of

Comment by gbtami: General Comment: Changed it, thx.! For more information: http://code.google.com/p/

Comment by lobais: Score: Positive General Comment: Works great For more information: http://code.

Comment by mattgatto: General Comment: Hmm, okay. I thought lib/widgets/ was for actual widgets (ie

Comment by lobais: General Comment: Yes. For more information: http://code.google.com/p/pychess/

Comment by Uncombed...@gmail.com: Score: Positive General Comment: I spend a good minute writing a

Comment by mattgatto: Score: Positive General Comment: Yeah thanks for doing this. I hated having to

Comment by gbtami: General Comment: Added which.py to hg from http://bugs.python.org/issue444582.