Require matching Thrift versions between client and server

[Daniel Lundin]

A quick patch to ensure thrift api versions is the same on client and
server side:

http://github.com/dln/pycassa/commit/bb83550df7f64dbd85255001ba8ad31a641a667b

[Tyler Hobbs]

This is nice, but I'm afraid it's also prohibitively strict.  I'm trying to determine
this exactly, but I think we can expect compatibility between versions that
differ only by a "bug" version, and perhaps compatibility between versions
that differ by a minor version (although the old version make lake features).

Disallowing any difference is too much, I think.

- Tyler

[Eric Evans]

On Fri, Aug 20, 2010 at 10:26 AM, Tyler Hobbs <ty...@riptano.com> wrote:
> This is nice, but I'm afraid it's also prohibitively strict.  I'm trying to
> determine
> this exactly, but I think we can expect compatibility between versions that
> differ only by a "bug" version, and perhaps compatibility between versions
> that differ by a minor version (although the old version make lake
> features).
>
> Disallowing any difference is too much, I think.

Right, it's always going to be X.Y.Z where Z indicates no change in
compatibility, and Y indicates a backward compatible change. The
important comparison here would be on X:

a.split(".")[0] == b.split(".")[0]

> On Fri, Aug 20, 2010 at 8:51 AM, Daniel Lundin <d...@eintr.org> wrote:
>>
>> A quick patch to ensure thrift api versions is the same on client and
>> server side:
>>
>>  http://github.com/dln/pycassa/commit/bb83550df7f64dbd85255001ba8ad31a641a667b

--
Eric Evans
john.er...@gmail.com

[Daniel Lundin]

Yeah, that makes perfect sense.

Updated the branch (http://github.com/dln/pycassa/tree/thrift-version-assert)

/d

[Tyler Hobbs]

Great.  I've pulled the changes.