Ignored issue patches

[Dylan Smith]

Hi,

I have created two issues, with patches included that fix the issues:

http://code.google.com/p/pyactiveresource/issues/detail?id=14

http://code.google.com/p/pyactiveresource/issues/detail?id=15

These were submitted back in October 22, 2011 yet still haven't received any response.

Should I normally submit patches to the mailing list to make sure they are visible?  Or is it just that this project is no longer active?

- Dylan

[Mark Roach]

Hi, Dylan. I just hadn't noticed these. Thanks for submitting them, I'll take a look now.

Thanks,

Mark

- Dylan

--
You received this message because you are subscribed to the Google Groups "pyactiveresource" group.
To post to this group, send email to pyactive...@googlegroups.com.
To unsubscribe from this group, send email to pyactiveresour...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/pyactiveresource?hl=en.

[Mark Roach]

These will need some tests. I'll get to them myself (probably next week) unless you feel like taking a crack at it.

[Dylan Smith]

Sorry for the delay.  I somehow didn't notice your second email requesting tests until yesterday.

The attached are the revised patches that fix the same issues and include tests.

[Dylan Smith]

Ping. Any problems with the updated patches?

On Mar 20, 10:15 am, Dylan Smith <dylan.sm...@jadedpixel.com> wrote:
> Sorry for the delay.  I somehow didn't notice your second email requesting
> tests until yesterday.
>
> The attached are the revised patches that fix the same issues and include
> tests.
>
>
>
>
>
>
>
> On Tue, Feb 14, 2012 at 12:17 PM, Mark Roach <mark.r.ro...@gmail.com> wrote:
> > These will need some tests. I'll get to them myself (probably next week)
> > unless you feel like taking a crack at it.
>

> > On Tue, Feb 14, 2012 at 12:13 PM, Mark Roach <mark.r.ro...@gmail.com>wrote:
>
> >> Hi, Dylan. I just hadn't noticed these. Thanks for submitting them, I'll
> >> take a look now.
>
> >> Thanks,
>
> >> Mark
>

>  0001-Clear-errors-before-save.patch
> 3KViewDownload
>
>  0002-Add-support-for-primary_key-other-than-id.patch
> 5KViewDownload

[Mark Roach]

I think they've all been committed already. Let me check.

[Mark Roach]

Yup: http://code.google.com/p/pyactiveresource/source/list

[Dylan Smith]

I think you got it confused with another patch set.

The patches in this thread haven't been committed, so the issues I referenced at the start of this thread remain.