puppetlabs-* forge modules and 'parser = future'

[Tim Skirvin]

I decided to try out 'parser = future' today, and the first thing
to fail was puppetlabs-apache, with errors along the lines of:

Filepath: /srv/puppet/env/puppet/modules/apache/templates/httpd.conf.erb
Line: 19
Detail: comparison of Float with String failed

There's already a bug report for this[1], but that's not really
my point. I'm curious as to the larger questions - when are the modules
supported by PuppetLabs in the Forge going to be ready for use with the
future parser? And, when these modules are ready, how will we know? Will
it be listed as compatible with 4.0.0?

And until this is ready, is 'parser = future' doing much good?

- Tim Skirvin (tski...@fnal.gov)
--
HPC Systems Administrator / Developer http://www.linkedin.com/in/tskirvin
USCMS-T1 Collaboration Fermilab Scientific Computing

[1] https://tickets.puppetlabs.com/browse/MODULES-910

[Spencer Krum]

+1 for a plan for this

--
Spencer Krum
(619)-980-7820

[Jason Antman]

Yeah. I found an error in the puppetlabs-mcollective module (https://tickets.puppetlabs.com/browse/MODULES-1192) where it doesn't work with "trusted_node_data = true", which per the docs is a 3.6.2 recommended safe setting. When I was testing my fix, I made the mistake of running specs with future parser enabled... and saw how horribly they failed.

IMO at least for official modules (and ideally for use by anyone interested) there needs to be a single, centrally-managed list of puppet versions and parameters that are tested against. I know I've seen a few modules that still don't run specs with anything > 3.4.

--
You received this message because you are subscribed to the Google Groups "Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/CADt6FWOMjWQtszuwncC42Mgs%2BcBmuNF2tC8zyr%3DxdusXCObhFg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[Hunter Haugen]

On Thu, Sep 18, 2014 at 2:16 PM, Tim Skirvin <tski...@fnal.gov> wrote:

        I decided to try out 'parser = future' today, and the first thing
to fail was puppetlabs-apache, with errors along the lines of:

    Filepath: /srv/puppet/env/puppet/modules/apache/templates/httpd.conf.erb
    Line: 19
    Detail: comparison of Float with String failed

        There's already a bug report for this[1], but that's not really
my point.  I'm curious as to the larger questions - when are the modules
supported by PuppetLabs in the Forge going to be ready for use with the
future parser?  And, when these modules are ready, how will we know?  Will
it be listed as compatible with 4.0.0?

The feature for supporting unit testing with the future parser was added to puppetlabs_spec_helper in 0.6.0 https://github.com/puppetlabs/puppetlabs_spec_helper/blob/master/CHANGELOG#L36 in preparation for this.

We actually have a load of tickets in our next sprint to enable future parser testing on all of the supported modules and go through making them compatible, starting Oct 1st. Good timing on your question, bad timing that it's taken us this long to get to it :(.

[Henrik Lindberg]

On 2014-30-09 24:30, Hunter Haugen wrote:
>
> On Thu, Sep 18, 2014 at 2:16 PM, Tim Skirvin <tski...@fnal.gov
> <mailto:tski...@fnal.gov>> wrote:
>
> I decided to try out 'parser = future' today, and the first
> thing
> to fail was puppetlabs-apache, with errors along the lines of:
>
> Filepath:
> /srv/puppet/env/puppet/modules/apache/templates/httpd.conf.erb
> Line: 19
> Detail: comparison of Float with String failed
>
> There's already a bug report for this[1], but that's not really
> my point. I'm curious as to the larger questions - when are the modules
> supported by PuppetLabs in the Forge going to be ready for use with the
> future parser? And, when these modules are ready, how will we
> know? Will
> it be listed as compatible with 4.0.0?
>
>
> The feature for supporting unit testing with the future parser was added
> to puppetlabs_spec_helper in 0.6.0
> https://github.com/puppetlabs/puppetlabs_spec_helper/blob/master/CHANGELOG#L36
> in preparation for this.
>
> We actually have a load of tickets in our next sprint to enable future
> parser testing on all of the supported modules and go through making
> them compatible, starting Oct 1st. Good timing on your question, bad
> timing that it's taken us this long to get to it :(.
>
>

Sounds very good. As it happens I am on community rotation (triage, PRs
etc.) while you are working on this so feel free to ping me for help
untangling issues, and fixing bugs that show up.

> And until this is ready, is 'parser = future' doing much good?
>

Absolutely - we are having this discussion now instead of after 4.0 is
released :-)

Regards
- henrik

> - Tim Skirvin
> (tski...@fnal.gov <mailto:tski...@fnal.gov>)

> --
> HPC Systems Administrator / Developer
> http://www.linkedin.com/in/tskirvin
> USCMS-T1 Collaboration Fermilab Scientific
> Computing
>
> [1] https://tickets.puppetlabs.com/browse/MODULES-910
>
>

--

Visit my Blog "Puppet on the Edge"
http://puppet-on-the-edge.blogspot.se/

[Tim Skirvin]

Hunter Haugen <hun...@puppetlabs.com> writes:

> We actually have a load of tickets in our next sprint to enable future
> parser testing on all of the supported modules and go through making them
> compatible, starting Oct 1st. Good timing on your question, bad timing that
> it's taken us this long to get to it :(.

I'm glad to hear that you're looking into this, at any rate.
Thanks!