Trouble with class with _ in name

[Matthew Kennedy]

I have code that pulls in profiles.

    if (defined("profile::${separator}::${profile}")) {

      include "profile::${separator}::${profile}"

    }

$separator will be something like 'app' or 'role'

$profile will be something like 'blah' or 'blah_app'

The profile classes looks like

class profile::app::blah (

) {

  notify { 'I am blah': }

}

or 

class profile::app::blah_app (

) {

  notify { 'I am blah_app': }

}

The problem is that if I have a profile with an underscore (blah_app) the profile is not found otherwise the code works as intended.  As far as I understand _ is a permissible for class names.

I'm using latest 3.7.3

Any help would be appreciated.

[Matthew Kennedy]

Well, I did a downgrade to 3.7.2 and this issue no longer appears.  It appears there is a regression on 3.7.3.  I'll submit a bug.

[Matthew Kennedy]

Submitted issue https://tickets.puppetlabs.com/browse/PUP-3799

On Tuesday, December 30, 2014 10:35:01 AM UTC-7, Matthew Kennedy wrote:

[Felix Frank]

On 12/30/2014 09:05 PM, Matthew Kennedy wrote:

    if (defined("profile::${separator}::${profile}")) {

      include "profile::${separator}::${profile}"

    }

Hi,

Is the if defined() construct significant? Can you only reproduce when it is in place? Why is it there and what does it do?

Note that, regardless of this issue, using this function can be hazardous.

Thanks,
Felix

[Matthew Kennedy]

No, if you remove the defined() call and just include it will fail to find the class. Defined() is there simply to ensure that we can do the include.  For a bit more context I've written an abstraction layer that assigns apps/roles to nodes and will pull in profiles if they exist, that is where this snipit is from.  

So changing this to:

if ($profile == 'existantclass') {

  include "profile::${separator}::${profile}"
}

results in Error 400 on SERVER: Could not find class profile::app::existantclass for node1.vnet on node node1.vnet.

Me and defined() have had a rocky but ultimately agreeable relationship. 

[Felix Frank]

On 01/07/2015 08:18 PM, Matthew Kennedy wrote:

So changing this to:

if ($profile == 'existantclass') {
  include "profile::${separator}::${profile}"
}

results in Error 400 on SERVER: Could not find class profile::app::existantclass for node1.vnet on node node1.vnet.

Wait, what, so the underscore is not relevant after all?

[Matthew Kennedy]

Gosh sorry, would be something like existant_class.