POC Update for PuppetForce Apache Module

[A J]

Hello,

I am new to distributed development and Puppet.  The one thing that was bothering since I started learning this product is the lack of ability to run more than one instance of Apache per host.

I actually like the PuppetForge Apache module for the most part, so I have made some changes to it as a Proof-of-Concept for RedHat that allows you to run multiple instances.

My question is that I get confused by the documentation, etc. on how best to submit this for review to the community, without actually causing any problems.

Could someone help direct me as to the correct way to make this submission?

Thanks!

[Hunter Haugen]

Hi AJ!

Ooo, this sounds like a desirable feature for the apache module.

Our docs on this are basically what is described in https://github.com/puppetlabs/puppetlabs-apache/blob/master/CONTRIBUTING.md though it is not very verbose. Github documentation on creating a pull request is at https://help.github.com/articles/creating-a-pull-request/

If you have contributions to CONTRIBUTING.md (hah) then the master copy is held at https://github.com/puppetlabs/modulesync_configs/blob/master/moduleroot/CONTRIBUTING.md

It also helps speed up the process if you ping us on the #puppet-dev freenode channel and get real-time feedback.

[Evan Hisey]

AJ-

  Out of curiosity why would you want more than one instance of apache per host? I can't think of a situation that can't be handled by a single apache server other than maybe running to different versions of apache at once, and I am not sure when I would need to do that.

Evan

--
You received this message because you are subscribed to the Google Groups "Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/CAJaQvGDmeyH_D-D_MDjDO-0GGO7kvAWgNG4%2BUUD%2B6nxOaQ9DNQ%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

[Ramin K]

Run as different users. Run with different modules. Even different mpms.
Fairly common scenario in shared web hosting.

Ramin

> <mailto:puppet-users...@googlegroups.com>.

> To view this discussion on the web visit
> https://groups.google.com/d/msgid/puppet-users/CAJaQvGDmeyH_D-D_MDjDO-0GGO7kvAWgNG4%2BUUD%2B6nxOaQ9DNQ%40mail.gmail.com

> <https://groups.google.com/d/msgid/puppet-users/CAJaQvGDmeyH_D-D_MDjDO-0GGO7kvAWgNG4%2BUUD%2B6nxOaQ9DNQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.

>
> For more options, visit https://groups.google.com/d/optout.
>
>

> --
> You received this message because you are subscribed to the Google
> Groups "Puppet Users" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to puppet-users...@googlegroups.com

> <mailto:puppet-users...@googlegroups.com>.

> To view this discussion on the web visit

> https://groups.google.com/d/msgid/puppet-users/CAEcFzYxb%2BVdiGfonJ5qapqwJg4s5dNoiaDm3Q0pyRUPs-OHcEA%40mail.gmail.com
> <https://groups.google.com/d/msgid/puppet-users/CAEcFzYxb%2BVdiGfonJ5qapqwJg4s5dNoiaDm3Q0pyRUPs-OHcEA%40mail.gmail.com?utm_medium=email&utm_source=footer>.

[A J]

Hello again,

I have my code changes forked off the GITHUB for puppetlabs and my changes on a branch.

What I am not sure of is how to   'Submit a pull request to the repository in the puppetlabs organization.'  , and I was hoping that someone could help me with this part of the process.

I know the code is not perfect, but I figured there are enough other talented people that it should be easy enough for them to get it finished up and ready for use.

Thanks!

[Thomas Müller]

I have my code changes forked off the GITHUB for puppetlabs and my changes on a branch.

What I am not sure of is how to   'Submit a pull request to the repository in the puppetlabs organization.'  , and I was hoping that someone could help me with this part of the process.

the github help to pull requests: https://help.github.com/articles/using-pull-requests/

IMHO the pull request has to be file against puppetlabs/puppetlabs-apache . Where as "puppetlabs/" is "the puppetlabs organization".

- Thomas