puppetlabs/activemq module

64 views
Skip to first unread message

John Anderson

unread,
Oct 30, 2014, 8:51:25 PM10/30/14
to puppet...@googlegroups.com
I'm fairly sure that puppetlabs uses their activemq module internally to manage the activemq component of mcollective.   I'm interested in contributing an ActiveMQ module myself, one that is for more general use.  I'm not sure if I should contribute and expand the functionality of PuppetLabs ActiveMQ module, contribute to another ActiveMQ module, or create a new one.

When read the guide on forge contributions, the first step is to open an issue for the bug or feature, and it appears as though issues are disabled for the PuppetLabs/ActiveMQ module, however I do see pull requests.

The features I'd like to add over multiple phases are:

Support for choosing a persistence engine (KahaDB, LevelDB, MySQL, whatever else is supported). 
Support for creating a network of brokers.
Support for HA scenarios, such as Zookeeper or shared storage configurations.

In short, there are lot of deployment configurations for ActiveMQ, and I'd like to help the main PuppetLabs module support as many as possible, I'm just not quite sure where to begin as far as collaboration with PuppetLabs is concerned.   If PuppetLabs would like to keep their ActiveMQ module tuned for the puppet application stack, which module should I then proceed to contribute this functionality toward?


John A.

Ryan Coleman

unread,
Oct 30, 2014, 9:22:01 PM10/30/14
to puppet...@googlegroups.com
On Thu, Oct 30, 2014 at 5:51 PM, John Anderson <ja39...@gmail.com> wrote:
I'm fairly sure that puppetlabs uses their activemq module internally to manage the activemq component of mcollective.   I'm interested in contributing an ActiveMQ module myself, one that is for more general use.  I'm not sure if I should contribute and expand the functionality of PuppetLabs ActiveMQ module, contribute to another ActiveMQ module, or create a new one.

When read the guide on forge contributions, the first step is to open an issue for the bug or feature, and it appears as though issues are disabled for the PuppetLabs/ActiveMQ module, however I do see pull requests.

Hi John. We migrated from GitHub Issues to Jira a while back. It looks like activemq was never updated to point there. Sorry about that. We track in the MODULES project which you can find here: https://tickets.puppetlabs.com/browse/MODULES

That said, you're more than welcome to fork our module as a base to start from or offer contributions back. We do review and merge in any reasonable contribution we get but this particular module is in the lower half of our list so response times may vary. As the README indicates, it's primarily intended for MCollective but I don't see why it couldn't be expanded for general use. 
 

The features I'd like to add over multiple phases are:

Support for choosing a persistence engine (KahaDB, LevelDB, MySQL, whatever else is supported). 
Support for creating a network of brokers.
Support for HA scenarios, such as Zookeeper or shared storage configurations.

In short, there are lot of deployment configurations for ActiveMQ, and I'd like to help the main PuppetLabs module support as many as possible, I'm just not quite sure where to begin as far as collaboration with PuppetLabs is concerned.   If PuppetLabs would like to keep their ActiveMQ module tuned for the puppet application stack, which module should I then proceed to contribute this functionality toward?


John A.

--
You received this message because you are subscribed to the Google Groups "Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/1222294e-531f-4521-9c4f-9b07df086c12%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.



--
Ryan Coleman | Modules & Forge | ryanycoleman on twitter & #puppet IRC
 

John Anderson

unread,
Oct 31, 2014, 5:06:19 AM10/31/14
to puppet...@googlegroups.com
Okay, that sounds like a plan to me.

I have just one question though, should I put in a JIRA ticket before I start working on code like the guide suggests?  Or should I fork it, adapt it to my needs, and then make a JIRA ticket when I have something clean to contribute back?

The latter option seems the most logical.

John A.

Ryan Coleman

unread,
Oct 31, 2014, 10:47:31 AM10/31/14
to puppet...@googlegroups.com
On Fri, Oct 31, 2014 at 2:06 AM, John Anderson <ja39...@gmail.com> wrote:
Okay, that sounds like a plan to me.

I have just one question though, should I put in a JIRA ticket before I start working on code like the guide suggests?  Or should I fork it, adapt it to my needs, and then make a JIRA ticket when I have something clean to contribute back?

The latter option seems the most logical.

Yeah, makes sense to me too. The spirit of that part of the guide is for things like a minor feature request or bug report, giving people an opportunity to call out duplicate work before someone spends a lot of time on it. 

Thanks John !
 

John A.

On Thursday, October 30, 2014 6:22:01 PM UTC-7, Ryan Coleman wrote:


On Thu, Oct 30, 2014 at 5:51 PM, John Anderson <ja39...@gmail.com> wrote:
I'm fairly sure that puppetlabs uses their activemq module internally to manage the activemq component of mcollective.   I'm interested in contributing an ActiveMQ module myself, one that is for more general use.  I'm not sure if I should contribute and expand the functionality of PuppetLabs ActiveMQ module, contribute to another ActiveMQ module, or create a new one.

When read the guide on forge contributions, the first step is to open an issue for the bug or feature, and it appears as though issues are disabled for the PuppetLabs/ActiveMQ module, however I do see pull requests.

Hi John. We migrated from GitHub Issues to Jira a while back. It looks like activemq was never updated to point there. Sorry about that. We track in the MODULES project which you can find here: https://tickets.puppetlabs.com/browse/MODULES

That said, you're more than welcome to fork our module as a base to start from or offer contributions back. We do review and merge in any reasonable contribution we get but this particular module is in the lower half of our list so response times may vary. As the README indicates, it's primarily intended for MCollective but I don't see why it couldn't be expanded for general use. 
 

The features I'd like to add over multiple phases are:

Support for choosing a persistence engine (KahaDB, LevelDB, MySQL, whatever else is supported). 
Support for creating a network of brokers.
Support for HA scenarios, such as Zookeeper or shared storage configurations.

In short, there are lot of deployment configurations for ActiveMQ, and I'd like to help the main PuppetLabs module support as many as possible, I'm just not quite sure where to begin as far as collaboration with PuppetLabs is concerned.   If PuppetLabs would like to keep their ActiveMQ module tuned for the puppet application stack, which module should I then proceed to contribute this functionality toward?


John A.

--
You received this message because you are subscribed to the Google Groups "Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/1222294e-531f-4521-9c4f-9b07df086c12%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.



--
Ryan Coleman | Modules & Forge | ryanycoleman on twitter & #puppet IRC
 

--
You received this message because you are subscribed to the Google Groups "Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-users...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.
Reply all
Reply to author
Forward
0 new messages