puppet 3.6.2, parse time error about storeconfigs

72 views
Skip to first unread message

Tristan Smith

unread,
Nov 5, 2014, 7:30:05 PM11/5/14
to puppet...@googlegroups.com
So, I'm trying to be a good citizen and use more forge code. I run puppet parser validate across all manifests as part of this - which results in much hilarity and tears.

The latest one was when I pulled in puppetlabs/apache.

.../modules/apache/manifests$ puppet parser validate balancer.pp --parser=future
Warning: You cannot collect exported resources without storeconfigs being set; the collection will be ignored at .../modules/apache/manifests/balancer.pp:65:5
.../modules/apache/manifests$ puppet parser validate balancer.pp --parser=future --storeconfigs=true
Error: Could not parse application options: needless argument: --storeconfigs=true

In general, warnings have been about things that I should care about, and I enforce them, but this one's just plain improper. 

Am I off base, or should this be a bug report against puppet's parser? (btw: future or not future, same result.)

--Triss

Henrik Lindberg

unread,
Nov 5, 2014, 8:11:21 PM11/5/14
to puppet...@googlegroups.com
On 2014-06-11 1:30, Tristan Smith wrote:
> So, I'm trying to be a good citizen and use more forge code. I run
> puppet parser validate across all manifests as part of this - which
> results in much hilarity and tears.
>
> The latest one was when I pulled in puppetlabs/apache.
>
> .../modules/apache/manifests$ puppet parser validate balancer.pp
> --parser=future
> Warning: You cannot collect exported resources without storeconfigs
> being set; the collection will be ignored at
> .../modules/apache/manifests/balancer.pp:65:5
> .../modules/apache/manifests$ puppet parser validate balancer.pp
> --parser=future --storeconfigs=true
> Error: Could not parse application options: needless argument:
> --storeconfigs=true
>
> In general, warnings have been about things that I should care about,
> and I enforce them, but this one's just plain improper.
>
The warning is issues because the code contains collection of exported
resources. It is a known issue that this should not be a parse time
warning since the environment where parsing/validation takes place does
not have to have storeconfigs set at all (the result is the same anyway,
the difference is when running that code).

The future parser has the same warning "to be compatible".

We will fix this during the 4x series if it does not make it in time for
Puppet 4.0

If you really want to not see the error, you have to configure
storeconfigs:
http://projects.puppetlabs.com/projects/1/wiki/using_stored_configuration -
which as you can see in that information is deprecated if you want to
use Rails and ActiveRecord, in favor of PuppetDB. This means you have to
have a PuppetDb set up when you are validating... (and the lines of yaks
requiring a haircut keeps piling up).


> Am I off base, or should this be a bug report against puppet's parser?
> (btw: future or not future, same result.)
>

No need, it is a known issue (if you are referring to the pointless
warning about storeconfigs when there is a collection of exported
resources in the code).

Regards
- henrik

--

Visit my Blog "Puppet on the Edge"
http://puppet-on-the-edge.blogspot.se/

Tristan Smith

unread,
Nov 6, 2014, 7:14:27 PM11/6/14
to puppet...@googlegroups.com
Thanks, I failed to find it in Jira. Glad to know it's something already in the roadmap.



--
You received this message because you are subscribed to a topic in the Google Groups "Puppet Users" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/puppet-users/EKlG7O_S6PE/unsubscribe.
To unsubscribe from this group and all its topics, send an email to puppet-users+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/m3ehqq%24hev%241%40ger.gmane.org.

For more options, visit https://groups.google.com/d/optout.

Henrik Lindberg

unread,
Nov 7, 2014, 9:50:14 PM11/7/14
to puppet...@googlegroups.com
On 2014-07-11 1:14, Tristan Smith wrote:
> Thanks, I failed to find it in Jira. Glad to know it's something already
> in the roadmap.
>
Yeah, it is in a ticket that is about removing validation from the
grammar (or somesuch).

- henrik

> On Wed, Nov 5, 2014 at 5:10 PM, Henrik Lindberg
> <henrik....@cloudsmith.com <mailto:henrik....@cloudsmith.com>>
> wrote:
>
> On 2014-06-11 1:30, Tristan Smith wrote:
>
> So, I'm trying to be a good citizen and use more forge code. I run
> puppet parser validate across all manifests as part of this - which
> results in much hilarity and tears.
>
> The latest one was when I pulled in puppetlabs/apache.
>
> ..../modules/apache/manifests$ puppet parser validate balancer.pp
> --parser=future
> Warning: You cannot collect exported resources without storeconfigs
> being set; the collection will be ignored at
> ..../modules/apache/manifests/__balancer.pp:65:5
> ..../modules/apache/manifests$ puppet parser validate balancer.pp
> --parser=future --storeconfigs=true
> Error: Could not parse application options: needless argument:
> --storeconfigs=true
>
> In general, warnings have been about things that I should care
> about,
> and I enforce them, but this one's just plain improper.
>
> The warning is issues because the code contains collection of
> exported resources. It is a known issue that this should not be a
> parse time warning since the environment where parsing/validation
> takes place does not have to have storeconfigs set at all (the
> result is the same anyway, the difference is when running that code).
>
> The future parser has the same warning "to be compatible".
>
> We will fix this during the 4x series if it does not make it in time
> for Puppet 4.0
>
> If you really want to not see the error, you have to configure
> storeconfigs:
> http://projects.puppetlabs.__com/projects/1/wiki/using___stored_configuration
> <http://projects.puppetlabs.com/projects/1/wiki/using_stored_configuration>
> - which as you can see in that information is deprecated if you want
> to use Rails and ActiveRecord, in favor of PuppetDB. This means you
> have to have a PuppetDb set up when you are validating... (and the
> lines of yaks requiring a haircut keeps piling up).
>
>
> Am I off base, or should this be a bug report against puppet's
> parser?
> (btw: future or not future, same result.)
>
>
> No need, it is a known issue (if you are referring to the pointless
> warning about storeconfigs when there is a collection of exported
> resources in the code).
>
> Regards
> - henrik
>
> --
>
> Visit my Blog "Puppet on the Edge"
> http://puppet-on-the-edge.__blogspot.se/
> <http://puppet-on-the-edge.blogspot.se/>
>
> --
> You received this message because you are subscribed to a topic in
> the Google Groups "Puppet Users" group.
> To unsubscribe from this topic, visit
> https://groups.google.com/d/__topic/puppet-users/EKlG7O___S6PE/unsubscribe
> <https://groups.google.com/d/topic/puppet-users/EKlG7O_S6PE/unsubscribe>.
> To unsubscribe from this group and all its topics, send an email to
> puppet-users+unsubscribe@__googlegroups.com
> <mailto:puppet-users%2Bunsu...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/__msgid/puppet-users/m3ehqq%__24hev%241%40ger.gmane.org
> <https://groups.google.com/d/msgid/puppet-users/m3ehqq%24hev%241%40ger.gmane.org>.
>
> For more options, visit https://groups.google.com/d/__optout
> <https://groups.google.com/d/optout>.
>
>
> --
> You received this message because you are subscribed to the Google
> Groups "Puppet Users" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to puppet-users...@googlegroups.com
> <mailto:puppet-users...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/puppet-users/CAKdO7cd9qVSdAYmBcuYzdiVTiZsrP%3DaPG2ovxH8hXdxPe%3DST4A%40mail.gmail.com
> <https://groups.google.com/d/msgid/puppet-users/CAKdO7cd9qVSdAYmBcuYzdiVTiZsrP%3DaPG2ovxH8hXdxPe%3DST4A%40mail.gmail.com?utm_medium=email&utm_source=footer>.
> For more options, visit https://groups.google.com/d/optout.


Reply all
Reply to author
Forward
0 new messages