Notes from PR Triage on April 2nd, 2014

[Adrien Thebo]

Pull request triage - 2014-04-02

Joined: Charlie, Erik, Finch, Felix, Henrik, Joshua, Ken, Kylo, Peter, Zach

Held over:

Puppet:

2366: pkgdmg errors on eject due to (at least) spotlight.

  - Still waiting to hear back

  - Asking Gary Larizza for his opinion.

  - The issue being solved shouldn't happen and can't be reproduced consistently

  - Closed by Kylo

2331: (PUP-1587) crontab: make sure that invalid crontabs aren't written out

  - Pull in for 3.6.0

  - deferring to next week

  - Charlie to take when he has time

  - Merged!

2311: (PUP-1547) Undefined method 'groups' for nil:NilClass when no providers found

  - We'd like to try this out and see if there's a better way to handle there not being any provider.

  - Joshua will take this

  - Got bumped from the sprint, Joshua still working on this

2309: Separate out hold state into a separate property:

  - Would rather see held stay as ensure and a version parameter pulled out.

  - Finch to add comment -- Adrien will start a puppet-dev conversation

  - Push to lollipopman to start puppet-dev convo

  - Conversation started, now we wait for a resolution

  - [link](https://groups.google.com/forum/#!topic/puppet-dev/_APn8ZXw4Cw)

Facter:

566: (#23269) Handle non-utf8 in dmidecode/smbios output

  - Passing over for next week, Adrien may need to change it

  - Adrien to try to pull into this next sprint

  - PR ready, Kylo to take

580: (FACT-166) change acceptable fact names to be only lowercase Symbols

  - Skipping over for next week

  - Kicking over to Kylo for some guidance on where to take this work.

  - Kicking the can down another week

608: Fix to Virtual Machine detection on Darwin

  - Needs commit message updated to include ticket number 

  - Needs to be pulled into a sprint. Probably make it into 2.0.2 or 2.1

  - Adrien to clean up/merge

642: Update facter PR 617 - AIX netmask (FACT-247)

  - Still waiting for Moses.

  - Adrien to harass Moses.

  - Adrien to continue to harass Moses

Puppet:

2428: (maint) Use git mirrors for puppet/hiera/facter installation

  - Joshua to just merge it in.

  - Got pushed off because we were overloaded

  - Merged!

2420: Disambiguation of handling source_or_content for fileservers vs local re...

  - Don't know what the fix is for. Asked user to open a ticket with a reproduction case.

  - Contributor working on fixing up and adding tests

  - Fixes made, PUP-1892 opened to detail the problem

  - Specs don't make a lot of sense with respect to the issue being fixed

  - Joshua to follow up on the spec to sort that out.

1974: enablerepo and disablerepo for yum type:

  - Lots of going in circles. The consensus us that install_options is the right way to go, but because of some confusion about prefetch. Adding a new parameter to the type is not wanted because it makes the package type have some *very* yum specific functionality. The real solution, but not one we can get right now, is to allow providers to specialize a type and add provider specific parameters.

  - Kylo to respond with some information about us being wrong about our last response.

  - Contributor seemed on board to the approach we suggested, let's see if he follows up. If not we can just take this and fix it ourselves.

2033: Implement feature :upgradeable for OpenBSD package provider.

  - Hasn't seen activity for a while. We aren't currently interested in trying to maintain BSDs ourselves and so we are just going to close it out.

  - Adrien will ping Zach Leslie to see if he is interested.

  - Zach to look at it, Adrien to try to keep it moving and close it if he can't do so.

2082: Add install options apt

  - this has been sitting around for a long time. We now have a lot of examples of install_options being used.

  - PeterH will point the user to those implementations so that it can follow the same pattern.

  - PeterH to fix up/merge

2136: For puppet4 (#11383) support purging of all cronjobs

  - Still on hold. Felix will look at getting a PR for a deprecation warning.

  - Still waiting for the puppet-4 branch to continue forward on this.

2245: Test for nil file path and output different error if path is undef

  - Ends up giving misleading error messages.

  - Adrien closing because it hasn't had any activity.

  - Closed.

2253 - Add spec test for skeleton for generated modules:

  - Merged!

2254 - Add Rakefile to skeleton for generated modules:

  - Both of these seem ok. Adrien is checking with Ashley. Ashley was +1. Adrien to merge

  - Merged!

2262 - Fix yum/rpm version comparison to work the way RPM actually does:

  - We'll take this into puppet 4.

  - Also waiting for the puppet-4 branch.

2432 - Calling 'ruby' in Windows Tests Fails for PE:

  - Kylo will just merge it in right now.

  - Merged

2436 - Use metadata.json as canonical metadata source.

  - Andy has a meeting with PieterV tomorrow to discuss some PMT changes, will bring this up.

  - ??? - check in with Andy next week

2440 - Update `puppet module generate` to create `metadata.json`:

  - ditto

2437 - Egrammar fix

  - Andy to close since it doesn't look like it is something we want.

  - Closed

2451 - Add an sha256 checksum type to Puppet::Util::Checksums:

  - Looks like a good incremental move toward better FIPS handling.

  - Rob to merge in.

  - Merged!

2452 - Make the digest algorithm used for file checksums configurable:

  - Looks very reasonable. We'll pull this in the next sprint as our big item to consider from the PR submissions.

  - Got kicked out of last sprint due to lack of time, we'll try again this week

Hiera:

185 - Hi 127 escaped lookups:

  - Prefer the "literal" function since it is much more explicit. We'll leave out the alias for %{%} and also keep the %{} trick as undefined behavior.

  - Charlie to fix it up and just merge it in himself.

  - Merged!

New:

2492: (PUP-1381) issue warnings to current users of cron purging

  - See also: https://github.com/puppetlabs/puppet/pull/2136

  - Felix not really happy with this, would generate a lot of noise. How do we log this information without spewing too many messages? Only emit warnings if purging is enabled? Can we emit warnings in Type#finish when a resource is being purged?

  - Felix to continue to work on this and possibly work on a more general solution.

2495: Implement :enableable for OpenBSD service provider

  - Generally looks good, Zach will make minor changes for things like comments and `@api private`.

  - Pulling into the incoming sprint

Puppetdb!

900: Add subqueries to events query endpoint

  - kbarber asks - are there any other sort of queries/low hanging fruit that we

    can handle with this?

  - Generally good but needs tests. Tests discussion will be done offline.

    kbarber and dalen to follow up later.

891: fix storeconfig export for array values (PDB-518)

  - We need acceptance test coverage for the storeconfig import tool

  - puppetdb team to bring it into their sprint.

892: Use the puppet agent configprint to get local certificate informations

  - Unclear as to whether master cert or agent cert should be used. Master is currently used, some users want to use agent.

  - Switching from master to agent as default value may be backwards incompatible

  - Short term - explore a switch. Long term - persist switch setting so that upgrades don't potentially change the cert.

  - puppetdb team to take discussion back to the mailing list

Puppet!

2494: Change Crypto Spec in accordance to bettercrypto.org

  - Algorithms for passenger conf haven't been updated in 5 years.

  - pull request specifically enumerates secure algorithms to avoid the limitations of what openssl versions call "high" and "medium" algorithms.

  - Is this informational only or do we include this in any packages?

  - Might need to check the versions of openssl that Puppet supports to confirm it contains the cipher suites specified by this change.

  - Revisit for next sprint, we probably have enough work as-is.

2489: (PUP-2101) resource parser: add the resource name on the validation erro...

  - Trivial fix to create_resources, needs fixes to specs and commit message.

  - Charlie to take.

2488: (maint) Add travis notifications to #puppet-dev

  - consensus: merge it and see how much it affects IRC.

  - merged!

2487: (PUP-2098) 'only_uid' property on resources 'user'

  - Seems to be a complement to `unless_uid`

  - `unless_uid` accepts ranges, `only_uid` doesn't. No shared implementation between the two parameters, generally there are concerns about the implementation.

  - Is this behavior that we really need to support? Are there alternatives?

  - Felix to comment on the PR for more information.

2485: (PUP-2096) Support alternate http client classes in http_pool

  - motivated by running Puppet in the JVM, need to be able to specify alternate

    http implementations. (as indicated by the title)

  - Adds more global state :( has Java-isms :C

  - Bring in the underlying issue (PUP-2096) and discuss it in the planning meeting

  - Andy Parker may have been part of the conversation, let's dump the issue on him. (When he's feeling better.)

2483: Maint: Fix buggy auth.conf example in fileserver.conf

  - Merged!

Candidates for the upcoming sprint:

  - 2452 - Make the digest algorithm used for file checksums configurable:

  - 2495: Implement :enableable for OpenBSD service provider

  - 2311: (PUP-1547) Undefined method 'groups' for nil:NilClass when no providers found

  - 2420: Disambiguation of handling source_or_content for fileservers vs local re...

  - 2485: (PUP-2096) Support alternate http client classes in http_pool

  - 2082: Add install options apt

--

Adrien Thebo | Puppet Labs