Puppet PR Triage Notes 2014-07-09
10 views
Skip to first unread message
Andy Parker
Jul 9, 2014, 2:09:19 PM7/9/14
to puppe...@googlegroups.com
Joined: Andy, Adrien, Whopper
Candidates for merging:
* Puppet/2779: (PUP-2802) add slot support for packages in portage.rb
* Puppet/2770: Allow version and held states of a package to specified as separate properties
* Hiera/198: Add YAML output format to CLI
* Facter/722: (FACT-621) Add OpenBSD support for 'partitions' fact.
* Facter/720: (FACT-617) Facter README.md should express semver
* Hiera/205: (HI-279) Hiera README.md should express semver
New:
Puppet:
2843: Maint/mount doc wording
- Looks good
- Andy merged
Facter:
722: (FACT-621) Add OpenBSD support for 'partitions' fact.
- Looks good
- Adrien merged
721: (FACT-612) Add structured uptime fact
- Retarget and fix up of Facter/712
- Initial pass looks good.
- Adrien to look at
720: (FACT-617) Facter README.md should express semver
- Looks alright. There are some comments about it but the puppet doc is the exact same wording. This change will get them in sync.
- Will pull in for merge.
719: Ensure only major and minor versions are returned for CentOS 7.
- No jira issue
- Commit message needs
- No tests
- Need CLA signed
- Need a better explanation of why this change is needed. Why isn't the release version just the release version?
715: (MAINT) Switch bare 'sysctl' call to use Facter::Util::POSIX.sysctl
- Close down and just handle it in 721 since it is making a bunch of other changes to uptime
702: (FACT-598) Use `hostname -f` for `fqdn` if available.
- This would cause a change to how facter issues the fqdn fact, which could change a lot of stuff
- The user admits that they are using non-standard hostname setups
- This would be better done as a custom fact.
- We made all of the above decisions last time, but Adrien is going to research into this and come to a final determination and reasoning.
Hiera:
205: (HI-279) Hiera README.md should express semver
- Same as Facter/720
Held Over:
Hiera:
198: Add YAML output format to CLI
- Consensus is that the feature addition is good
- Adrien to do any fix ups and get it merged
193: The hierarchy should dynamically grow if an interpolated variable contains an Array type of value
- The request is reasonable within the user's context. Rather than adding yet more choices into hiera itself, we'd like to see this fixed by making the hierarchy mechanism plug able.
- Adrien to comment and close
188: Allow for return of complex values across hiera
- This will end up changing the behavior of some current queries.
- Better is to have it use another pseudo-function for "alias" that has rules that only one alias is allowed and no
- Adrien provided a great example of the unexpected consequences it could have.
- Back in the contributor's court for them to figure out if there is another design.
Puppet:
2831: (CPR-42) file conflict upgrading from 2.7.26 to 3.6.2
- Needs to reference a PUP ticket
2820: (PUP-2867) Support ~ in file paths, allows to deploy to ~<user> directories
- Already in discussion on puppet-dev
2779: (PUP-2802) add slot support for packages in portage.rb
- Adrien needs to take it an review it for correctness/more intensive review
- Commits need to be updated to contributing guidelines
2770: Allow version and held states of a package to specified as separate properties
- Pull in for more intensive analysis
- Commits need to be updated to contributing guidelines
- Backwards compat problems because of the new parameters.
- Adrien to summarize discussion
2614: (PUP-2452) Refresh support for Package type
- Looks reasonable.
- There is a question from the contributor about if there needs to be something changed to use this.
- The answer to the question is, "yes, having a use of this is ideal".
- Adrien noted that using the :methods system for the feature is hard to control. Better is to require that the provider just explicitly declare the feature, which it already does.
- Another concern came up about getting refresh events that will cause unintended reinstalls. Such a case is when a class contains a package and is the target of a notify.
- This is a larger change to functionality that we need to bring up on puppet-dev to figure out how to deal with the unintended consequences of adding this functionality.
- Adrien to write up the concerns in the PR and start a thread on puppet-dev to come to a decision about how to better control refresh events.
2709 (PUP-2701): Add PMT build metadata.json tests
- Joshua Partlow to verify these on a few platforms before merging
- Found some failures on centos6; will update prs and then ask if Kurt can continue
--
Candidates for merging:
* Puppet/2779: (PUP-2802) add slot support for packages in portage.rb
* Puppet/2770: Allow version and held states of a package to specified as separate properties
* Hiera/198: Add YAML output format to CLI
* Facter/722: (FACT-621) Add OpenBSD support for 'partitions' fact.
* Facter/720: (FACT-617) Facter README.md should express semver
* Hiera/205: (HI-279) Hiera README.md should express semver
New:
Puppet:
2843: Maint/mount doc wording
- Looks good
- Andy merged
Facter:
722: (FACT-621) Add OpenBSD support for 'partitions' fact.
- Looks good
- Adrien merged
721: (FACT-612) Add structured uptime fact
- Retarget and fix up of Facter/712
- Initial pass looks good.
- Adrien to look at
720: (FACT-617) Facter README.md should express semver
- Looks alright. There are some comments about it but the puppet doc is the exact same wording. This change will get them in sync.
- Will pull in for merge.
719: Ensure only major and minor versions are returned for CentOS 7.
- No jira issue
- Commit message needs
- No tests
- Need CLA signed
- Need a better explanation of why this change is needed. Why isn't the release version just the release version?
715: (MAINT) Switch bare 'sysctl' call to use Facter::Util::POSIX.sysctl
- Close down and just handle it in 721 since it is making a bunch of other changes to uptime
702: (FACT-598) Use `hostname -f` for `fqdn` if available.
- This would cause a change to how facter issues the fqdn fact, which could change a lot of stuff
- The user admits that they are using non-standard hostname setups
- This would be better done as a custom fact.
- We made all of the above decisions last time, but Adrien is going to research into this and come to a final determination and reasoning.
Hiera:
205: (HI-279) Hiera README.md should express semver
- Same as Facter/720
Held Over:
Hiera:
198: Add YAML output format to CLI
- Consensus is that the feature addition is good
- Adrien to do any fix ups and get it merged
193: The hierarchy should dynamically grow if an interpolated variable contains an Array type of value
- The request is reasonable within the user's context. Rather than adding yet more choices into hiera itself, we'd like to see this fixed by making the hierarchy mechanism plug able.
- Adrien to comment and close
188: Allow for return of complex values across hiera
- This will end up changing the behavior of some current queries.
- Better is to have it use another pseudo-function for "alias" that has rules that only one alias is allowed and no
- Adrien provided a great example of the unexpected consequences it could have.
- Back in the contributor's court for them to figure out if there is another design.
Puppet:
2831: (CPR-42) file conflict upgrading from 2.7.26 to 3.6.2
- Needs to reference a PUP ticket
2820: (PUP-2867) Support ~ in file paths, allows to deploy to ~<user> directories
- Already in discussion on puppet-dev
2779: (PUP-2802) add slot support for packages in portage.rb
- Adrien needs to take it an review it for correctness/more intensive review
- Commits need to be updated to contributing guidelines
2770: Allow version and held states of a package to specified as separate properties
- Pull in for more intensive analysis
- Commits need to be updated to contributing guidelines
- Backwards compat problems because of the new parameters.
- Adrien to summarize discussion
2614: (PUP-2452) Refresh support for Package type
- Looks reasonable.
- There is a question from the contributor about if there needs to be something changed to use this.
- The answer to the question is, "yes, having a use of this is ideal".
- Adrien noted that using the :methods system for the feature is hard to control. Better is to require that the provider just explicitly declare the feature, which it already does.
- Another concern came up about getting refresh events that will cause unintended reinstalls. Such a case is when a class contains a package and is the target of a notify.
- This is a larger change to functionality that we need to bring up on puppet-dev to figure out how to deal with the unintended consequences of adding this functionality.
- Adrien to write up the concerns in the PR and start a thread on puppet-dev to come to a decision about how to better control refresh events.
2709 (PUP-2701): Add PMT build metadata.json tests
- Joshua Partlow to verify these on a few platforms before merging
- Found some failures on centos6; will update prs and then ask if Kurt can continue
Andrew Parker
Freenode: zaphod42
Twitter: @aparker42
Software DeveloperRegister by May 30th to take advantage of the Early Adopter discount —save $349!
Reply all
Reply to author
Forward
0 new messages