Notes from PR Triage on March 26th, 2014

[Andy Parker]

Big decision made: We made are going to start the puppet-4 branch, create the build pipeline for it, and start taking some breaking changes.

Joined:

finch, zaphod42, kylo, jpartlow, peterhu, ferventcoder, JeremyH, felix

Held over:
Puppet:
2366: pkgdmg errors on eject due to (at least) spotlight. Needs a ticket. Moses: just do the eject (the temp copy is another way to fail). Adrien to add comments. -- still waiting to hear back Asking Garry Larizza for his opinion.
2327: Consensus reached! We'll pull it in for 3.6 -- Charlie to pull in  Closing in favor of 2331, which contains everything that is in this.
2331: Pull in for 3.6.0 -- defering to next week Charlie to take when he has time
2311 - Undefined method 'groups' for nil:NilClass when no providers found: We'd like to try this out and see if there's a better way to handle there not being any provider. -- Joshua will take this
2309 - Separate out hold state into a separate property: Would rather see held stay as ensure and a version parameter pulled out. Finch to add comment -- Adrien will start a puppet-dev conversation Push to lollipopman to start puppet-dev convo
2415: Dominic to rework using Puppet::Util::RubyGems Andy to take a look at and merge (also look into whether this should go onto stable branch).  Andy merged
2429: Peter Souter to fix specs PererH to take, since he is the "install options" man!  PeterH merged
Facter:
566: Passing over for next week, Adrien may need to change it Adrien to try to pull into this next sprint
580: Skipping over for next week Kicking over to Kylo for some guidance on where to take this work.
594: JoshC will comment on regex used for major release, waiting to hear back Adrien to pull in to make it into 2.0.1 Merged and in RC3
608: Needs commit message updated to include ticket number - Adrien Needs to be pulled into a sprint. Probably make it into 2.0.2 or 2.1
642: Still waiting for Moses. Adrien to harass Moses.
Hiera:

184: Andy to take and comment. We can't take it as is because it is backwards incompatible.
182: Henrik to open up a hiera ticket, fix up commits to reference it, and merge it in. Henrik merged

Puppet:

2428: Joshua to just merge it in. Got pushed off because we were overloaded
2449: Just needs a quick review. Seems good, though. Andy will grab. Andy merged
2413: Henrik to take this and help Stefan learn to do the rebase. Henrik merged
2444: Most likely good. Andy to pull into this sprint. Andy merged
2427: PeterH to close it as a dup of 2441
2420: Don't know what the fix is for. Asked user to open a ticket with a reproduction case. Contributor working on fixing up and adding tests
2323: Ping Haus and Moses again. Haus merged
2129: Adrien to make sure it is still good and merge it in. Adrien merged


New:

Puppet:

1974 - enablerepo and disablerepo for yum type: Lots of going in circles. The consensus us that install_options is the right way to go, but because of some confusion about prefetch. Adding a new parameter to the type is not wanted because it makes the package type have some *very* yum specific functionality. The real solution, but not one we can get right now, is to allow providers to specialize a type and add provider specific parameters. Kylo to respond with some information about us being wrong about our last response.

2033 - Implement feature :upgradeable for OpenBSD package provider. - Hasn't seen activity for a while. We aren't currently interested in trying to maintain BSDs ourselves and so we are just going to close it out. Adrien will ping Zach Leslie to see if he is interested.

2082 - Add install options apt: this has been sitting around for a long time. We now have a lot of examples of install_options being used. PeterH will point the user to those implementations so that it can follow the same pattern.

2122 - Feature #23359: Added support of http_proxy environment variable for pip…: This is another case of install_options being needed. It is so far off from that that we are just closing it out and suggesting that course of action. Charlie to close and comment.

2136 - For puppet4 (#11383) support purging of all cronjobs: Still on hold. Felix will look at getting a PR for a deprecation warning.

2245 - Test for nil file path and output different error if path is undef: Ends up giving misleading error messages. Adrien closing because it hasn't had any activity.

2253 - Add spec test for skeleton for generated modules:
2254 - Add Rakefile to skeleton for generated modules: Both of these seem ok. Adrien is checking with Ashley. Ashley was +1. Adrien to merge

2262 - Fix yum/rpm version comparison to work the way RPM actually does: We'll take this into puppet 4.

2432 - Calling 'ruby' in Windows Tests Fails for PE: Kylo will just merge it in right now.

2436 - Use metadata.json as canonical metadata source.: Andy has a meeting with PieterV tomorrow to discuss some PMT changes, will bring this up.
2440 - Update `puppet module generate` to create `metadata.json`: ditto

2437 - Egrammar fix: Andy to close since it doesn't look like it is something we want.

2451 - Add an sha256 checksum type to Puppet::Util::Checksums: Looks like a good incremental move toward better FIPS handling. Rob to merge in.

2452 - Make the digest algorithm used for file checksums configurable: Looks very reasonable. We'll pull this in the next sprint as our big item to consider from the PR submissions.

Hiera:

185 - Hi 127 escaped lookups: Prefer the "literal" function since it is much more explicit. We'll leave out the alias for %{%} and also keep the %{} trick as undefined behavior. Charlie to fix it up and just merge it in himself. 

--

Andrew Parker

an...@puppetlabs.com

Freenode: zaphod42

Twitter: @aparker42

Software Developer

Join us at PuppetConf 2014, September 23-24 in San Francisco - http://bit.ly/pupconf14