Puppet PR Triage starting in 30 minutes

29 views
Skip to first unread message

Josh Cooper

unread,
Nov 19, 2014, 12:29:56 PM11/19/14
to puppe...@googlegroups.com
The Puppet/Facter/Hiera PR triage will be starting in 30 minutes at http://links.puppetlabs.com/pr-triage

Josh

-- 
Josh Cooper
Developer, Puppet Labs

Join us at PuppetConf 2015, October 5-9 in Portland, OR - http://2015.puppetconf.com.  
Register early to save 40%!

Josh Cooper

unread,
Nov 20, 2014, 1:26:12 AM11/20/14
to puppe...@googlegroups.com
The notes from today's triage are posted at:
https://github.com/puppet-community/community-triage/blob/master/core/notes/2014-11-19.md

This time we focused on the oldest PR's against the puppet repo, and we managed to review all of them, except for Trevor's PR for https://github.com/puppetlabs/puppet/pull/3113. We'll get to that next time.

We recently switched to taking notes in the Github PRs directly -- fewer sources of truth that way. The above document has links for the Open and Closed pull requests for this week, so you can see what PRs were recently updated.

Let us know if you find the new format better, or not, or things that could be done better.

Josh


--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/53cee850-9fe6-46b5-bab4-9c0f48f6ce7b%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Felix Frank

unread,
Nov 20, 2014, 12:29:49 PM11/20/14
to puppe...@googlegroups.com
Hi,

I think this is a great way of handling this. It liberates us from the
secondary queue that was the notes document, getting dragged from one
week to the next. In fact, I think it would be even better to do away
with the whole notion of holding over PRs.

Instead, we could now quite easily
1. Visit all PRs that are not yet marked "Triaged".
2. Do everything else in strict "Least recently updated" order.

I believe that this would make sure that no PRs stay under the rug for
extended periods. Time to first feedback will be pretty low.

As for the notes document, that might be a good place to transcript some
of the discussion that is not strictly related to the PRs.

Cheers,
Felix
Reply all
Reply to author
Forward
0 new messages