Notes from PR Triage on January 29th, 2014

10 views
Skip to first unread message

Kylo Ginsberg

unread,
Jan 29, 2014, 2:05:54 PM1/29/14
to puppe...@googlegroups.com

Joined:


Adrien, Andy, Charlie, Erik D, Felix, Henrik, Igor, Josh C, Joshua P, Kylo, Peter


Good discussions this week, but I think I may have spaced out and forgotten some one. If so, mea culpa!

Items in strikethrough are closed so can come off the review list next week.


Puppet:


Held over 3x:


2137: Merged but reverted due to issues exposed by test failures. New pull request needed.

2200: It would cause a regression. Contributor pinged. Need some guidance on how to proceed. Peter and Kylo to work on this.

2212: Moses working on this with contributor.


Held over 2x:


stdlib:

198: Andy merged today.

204: This was closed two weeks ago. Real issue should be addressed in core. Kylo pinged Nan to create that issue so we can discuss there.

213: Merged


Held over 1x:


Puppet:

2288: Folded into Ashley’s pull and this one was closed.

2086: Ashley and Adrien will work out the details. Looks good. Want to change the provider name from ruby to ini file. WIP

2287: Merged

2286: Merged

2284: Merged

2282: Ashley to follow up with the contributor

2281: Merged

2277: Henrik will add a test and merge it in.

2276: Looks ok, but we need a little bit of backstory to justify that we can actually do this and needs a ticket. Adrien to look into

2269: Some packaging changes. Andy pinging Haus. WIP

2268: Closed. Ashley will fold it into the grand yumrepo fix up.

2243/2238/2237: One closed, Josh to follow-up on the other two, checking in with Adrien.

2236: Closed with comment.

2227/2226/2225/2130: Closed. See puppet-dev thread on tiering of providers, etc.


New:


Puppet:

2024 - Charlie to review, pull into next sprint

2060 - pull into sprint after this, pup-728

2247 - looks good but substantial, at next triage let's review whether we have bandwidth to tackle this

2301 - Peter to review, pulling into next sprint


--
Kylo Ginsberg

Join us at PuppetConf 2014September 23-24 in San Francisco - http://bit.ly/pupconf14
Register now and save 40%! Offer expires January 31st.
Reply all
Reply to author
Forward
0 new messages